From: Conor Dooley <conor@kernel.org>
To: JeeHeng Sia <jeeheng.sia@starfivetech.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leyfoon Tan <leyfoon.tan@starfivetech.com>,
Mason Huo <mason.huo@starfivetech.com>
Subject: RE: [PATCH v3 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk
Date: Fri, 03 Feb 2023 06:30:24 +0000 [thread overview]
Message-ID: <26A8AAC0-D477-45CD-A7D1-55218992B25F@kernel.org> (raw)
In-Reply-To: <debdfe40909c4b4787868b11730170c9@EXMBX066.cuchost.com>
On 3 February 2023 03:43:35 GMT, JeeHeng Sia <jeeheng.sia@starfivetech.com> wrote:
>
>
>> -----Original Message-----
>> From: Conor Dooley <conor@kernel.org>
>> Sent: Tuesday, 31 January, 2023 7:31 AM
>> To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; Alexandre Ghiti <alexghiti@rivosinc.com>
>> Cc: paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; linux-riscv@lists.infradead.org; linux-
>> kernel@vger.kernel.org; Leyfoon Tan <leyfoon.tan@starfivetech.com>; Mason Huo <mason.huo@starfivetech.com>
>> Subject: Re: [PATCH v3 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk
>>
>> +CC Alex
>>
>> Alex, could you take a look at the page table bits here when you get a
>> chance please?
>>
>> > + * @a0 - destination
>> > + * @a1 - source
>> > + */
>> > + .macro copy_page a0, a1
>> > + lui a2, 0x1
>> > + add a2, a2, a0
>> > +.1 :
>> > + REG_L t0, 0(a1)
>> > + REG_L t1, SZREG(a1)
>> > +
>> > + REG_S t0, 0(a0)
>> > + REG_S t1, SZREG(a0)
>> > +
>> > + addi a0, a0, 2 * SZREG
>> > + addi a1, a1, 2 * SZREG
>> > + bne a2, a0, .1
>>
>> allmodconfig, clang 15.0.4:
>>
>> <instantiation>:3:1: error: unexpected token at start of statement
>> .1 :
>> ^
>> /stuff/linux/arch/riscv/kernel/hibernate-asm.S:83:2: note: while in macro instantiation
>> copy_page a0, a1
>> ^
>> <instantiation>:12:15: error: unknown operand
>> bne a2, a0, .1
>> ^
>> /stuff/linux/arch/riscv/kernel/hibernate-asm.S:83:2: note: while in macro instantiation
>> copy_page a0, a1
>> ^
>> make[5]: *** [/stuff/linux/scripts/Makefile.build:384: arch/riscv/kernel/hibernate-asm.o] Error 1
>Hi Conor, I couldn't reproduce the above error, could you share the build command please?
It was just allmodconfig with LLVM=1
>>
>> > + .endm
>> > +
>> > #endif /* __ASM_ASSEMBLER_H */
>
>> Thanks,
>> Conor.
>
next prev parent reply other threads:[~2023-02-03 6:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 9:10 [PATCH v3 0/4] RISC-V Hibernation Support Sia Jee Heng
2023-01-27 9:10 ` [PATCH v3 1/4] RISC-V: Change suspend_save_csrs and suspend_restore_csrs to public function Sia Jee Heng
2023-01-30 23:31 ` Conor Dooley
2023-01-27 9:10 ` [PATCH v3 2/4] RISC-V: Factor out common code of __cpu_resume_enter() Sia Jee Heng
2023-01-30 21:49 ` Conor Dooley
2023-02-01 6:19 ` JeeHeng Sia
2023-01-27 9:10 ` [PATCH v3 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function Sia Jee Heng
2023-01-30 21:57 ` Conor Dooley
2023-01-31 8:19 ` Alexandre Ghiti
2023-02-01 5:48 ` JeeHeng Sia
2023-01-27 9:10 ` [PATCH v3 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk Sia Jee Heng
2023-01-30 23:30 ` Conor Dooley
2023-01-31 9:59 ` Alexandre Ghiti
2023-02-07 4:58 ` JeeHeng Sia
2023-02-07 5:27 ` Alexandre Ghiti
2023-02-02 2:43 ` JeeHeng Sia
2023-02-03 3:43 ` JeeHeng Sia
2023-02-03 6:30 ` Conor Dooley [this message]
2023-02-04 20:42 ` kernel test robot
2023-02-07 15:46 ` Alexandre Ghiti
2023-02-08 4:43 ` JeeHeng Sia
2023-02-08 12:04 ` Alexandre Ghiti
2023-02-09 6:12 ` JeeHeng Sia
2023-02-10 13:24 ` Alexandre Ghiti
2023-02-13 1:51 ` JeeHeng Sia
2023-02-14 6:57 ` Alexandre Ghiti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26A8AAC0-D477-45CD-A7D1-55218992B25F@kernel.org \
--to=conor@kernel.org \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=jeeheng.sia@starfivetech.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mason.huo@starfivetech.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®