From: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless-next 1/2] wifi: mac80211: validate SCAN_FLAG_AP in scan request during MLO
Date: Tue, 13 May 2025 15:47:12 +0530 [thread overview]
Message-ID: <26a9e68d-bce6-4bba-871d-13e2aeee3fed@oss.qualcomm.com> (raw)
In-Reply-To: <16499ad8e4b060ee04c8a8b3615fe8952aa7b07b.camel@sipsolutions.net>
On 5/13/2025 12:47 PM, Johannes Berg wrote:
> On Tue, 2025-05-13 at 09:26 +0530, Aditya Kumar Singh wrote:
>>
>> - if (sdata->deflink.u.ap.beacon &&
>> + if ((sdata->deflink.u.ap.beacon ||
>> + ieee80211_num_beaconing_links(sdata)) &&
>>
>
> Do we even still need the deflink check? Seems like
> num_beaconing_links() _should_ return 1 anyway even though it currently
> doesn't, and we need to fix that?
If the ieee80211_num_beaconing_links() is modified then deflink check is
not required. Do you want to me to send a clean up for that function
first or would take this and later the clean up part?
>
> Also seems the VLAN carrier handling is broken.
With this patch? Or in general you are saying? HWSIM test cases seems to
be working fine for me with this series applied. May be there is no test
case to make it evident?
--
Aditya
next prev parent reply other threads:[~2025-05-13 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 3:56 [PATCH wireless-next 0/2] wifi: mac80211: some bug fixes in MLO scan handling Aditya Kumar Singh
2025-05-13 3:56 ` [PATCH wireless-next 1/2] wifi: mac80211: validate SCAN_FLAG_AP in scan request during MLO Aditya Kumar Singh
2025-05-13 7:17 ` Johannes Berg
2025-05-13 10:17 ` Aditya Kumar Singh [this message]
2025-05-13 10:21 ` Johannes Berg
2025-05-13 10:32 ` Aditya Kumar Singh
2025-05-13 10:48 ` Johannes Berg
2025-05-13 10:56 ` Aditya Kumar Singh
2025-05-15 18:05 ` Aditya Kumar Singh
2025-05-13 3:56 ` [PATCH wireless-next 2/2] wifi: mac80211: accept probe response on link address as well Aditya Kumar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26a9e68d-bce6-4bba-871d-13e2aeee3fed@oss.qualcomm.com \
--to=aditya.kumar.singh@oss.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®