From: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless-next 1/2] wifi: mac80211: validate SCAN_FLAG_AP in scan request during MLO
Date: Thu, 15 May 2025 23:35:15 +0530 [thread overview]
Message-ID: <535df7b7-def9-4aac-8118-04e2fd0239d9@oss.qualcomm.com> (raw)
In-Reply-To: <772514cb-298a-40b0-9a33-a7dfcf037bd1@oss.qualcomm.com>
On 5/13/2025 4:26 PM, Aditya Kumar Singh wrote:
> On 5/13/2025 4:18 PM, Johannes Berg wrote:
>> On Tue, 2025-05-13 at 16:02 +0530, Aditya Kumar Singh wrote:
>>>
>>> Okay sure let me first send a clean up. So,
>>> ieee80211_num_beaconing_links() should return 1 for non-MLO as well?
>>>
>>
>> That would seem logical to me? For this and many other things non-MLO is
>> mostly equivalent to just having a single link (apart from the address
>> translation.)
>
> Yeah in a way true only.
>
>>
>>> And callers should test for == 1 instead of <= 1.
>>
>> Not even sure that matters enough to need to change?
> yeah can be left as it is. Sure then I will change the function alone to
> return 1 for non-MLO case as well.
>
> Thanks for the inputs :)
>
Done. Here is the clean up patch for review -
Link:
https://lore.kernel.org/all/20250515-fix_num_beaconing_links-v1-1-4a39e2704314@oss.qualcomm.com/
--
Aditya
next prev parent reply other threads:[~2025-05-15 18:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 3:56 [PATCH wireless-next 0/2] wifi: mac80211: some bug fixes in MLO scan handling Aditya Kumar Singh
2025-05-13 3:56 ` [PATCH wireless-next 1/2] wifi: mac80211: validate SCAN_FLAG_AP in scan request during MLO Aditya Kumar Singh
2025-05-13 7:17 ` Johannes Berg
2025-05-13 10:17 ` Aditya Kumar Singh
2025-05-13 10:21 ` Johannes Berg
2025-05-13 10:32 ` Aditya Kumar Singh
2025-05-13 10:48 ` Johannes Berg
2025-05-13 10:56 ` Aditya Kumar Singh
2025-05-15 18:05 ` Aditya Kumar Singh [this message]
2025-05-13 3:56 ` [PATCH wireless-next 2/2] wifi: mac80211: accept probe response on link address as well Aditya Kumar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535df7b7-def9-4aac-8118-04e2fd0239d9@oss.qualcomm.com \
--to=aditya.kumar.singh@oss.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®