From: Richard GENOUD <richard.genoud@bootlin.com>
To: Jisheng Zhang <jszhang@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Linus Walleij <linusw@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 00/13] arm64: add Synaptics SL2610 SoCs and RDK boards
Date: Wed, 18 Nov 2026 08:54:05 +0100 [thread overview]
Message-ID: <26aa0b74-e3f8-4405-ab87-743f5f8ef197@bootlin.com> (raw)
In-Reply-To: <avrx2EhgZ10ED40P@xhacker>
Le 16/11/2026 à 13:06, Jisheng Zhang a écrit :
> On Sun, Nov 15, 2026 at 06:23:39PM +0800, Jisheng Zhang wrote:
>> Add initial support for the Synaptics SL261X SoCs and corresponding
>> RDK boards.
>>
>> The SL261X SoCs include five pin-to-pin compatible SoCs: SL2611, SL2613,
>> SL2615, SL2617, and SL2619.
>>
>> Only reset, pinctrl, clk/pll, uart, gpio, i2c, spi, i3c are included in
>> this series. The support for Ethernet, USB, SDHCI, CAN, DMAC, XSPI will
>> be submitted after this series is merged.
>>
>> since v1:
>> - rebase on latest rcN
>> - drop some patches which have been merged
>> - let the "gbl" node export pinctrl/reset/clk devices with
>> MFD_CELL_NAME()
>> - use <linux/platform_device.h> instead of <linux/mod_devicetable.h>
>> - adopt some coding suggestions from Uwe
>> - Use 0 and 1 to select normal and strong pull-up on 10-bit pads
>
> Other SoCs doesn't use this defintion for pull up or strong pull up.
> After consulting our HW people, the strong pull up isn't used at
> all, so I will remove strong pull up support in newer version. We can
> add back its support when it's really needed in the future, nothing
> breaks.
I've found a similar definition here:
https://elixir.bootlin.com/linux/v7.3.1/source/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml#L73-L78
But also a plain new property here:
https://elixir.bootlin.com/linux/v7.3.1/source/Documentation/devicetree/bindings/pinctrl/starfive,jh7100-pinctrl.yaml#L153-L155
And another with the real strong pull-up value:
https://elixir.bootlin.com/linux/v7.3.1/source/Documentation/devicetree/bindings/pinctrl/thead,th1520-pinctrl.yaml#L94-L99
As you said, if it's not used, we can skip it and add a property in
the future (or the real value if we have it).
But we won't be able to use 1 for strong and 0 for normal.
Regards,
Richard
>
>> - collect Acked-by tag
>>
>> Jisheng Zhang (13):
>> arm64: kconfig: let ARCH_BERLIN cover Synaptics arm64 SoCs
>> pinctrl: berlin: use u16 instead of u8 for the offset
>> pinctrl: berlin: enable module build support
>> pinctrl: berlin: add optional pinconf support
>> dt-bindings: soc: synaptics: add SL2610 system controllers
>> soc: synaptics: add SL2610 system controller support
>> reset: add Synaptics SL2610 reset controller support
>> pinctrl: berlin: add Synaptics SL2610 pin controller support
>> clk: berlin: add Synaptics clock controller helpers
>> clk: berlin: add Synaptics SL2610 clocks and PLLs
>> dt-bindings: arm: berlin: add Synaptics SL2610 SoCs and RDK boards
>> arm64: dts: synaptics: add SL2610 family SoCs
>> arm64: dts: synaptics: add SL2610 family RDK boards
>>
>> .../bindings/arm/marvell,berlin.yaml | 20 +
>> .../soc/synaptics/syna,sl2610-soc-syscon.yaml | 178 ++++
>> MAINTAINERS | 8 +
>> arch/arm64/Kconfig.platforms | 4 +-
>> arch/arm64/boot/dts/synaptics/Makefile | 5 +
>> arch/arm64/boot/dts/synaptics/sl2611-rdk.dts | 16 +
>> arch/arm64/boot/dts/synaptics/sl2611.dtsi | 457 +++++++++++
>> arch/arm64/boot/dts/synaptics/sl2613-rdk.dts | 16 +
>> arch/arm64/boot/dts/synaptics/sl2613.dtsi | 12 +
>> arch/arm64/boot/dts/synaptics/sl2615-rdk.dts | 16 +
>> arch/arm64/boot/dts/synaptics/sl2615.dtsi | 46 ++
>> arch/arm64/boot/dts/synaptics/sl2617-rdk.dts | 16 +
>> arch/arm64/boot/dts/synaptics/sl2617.dtsi | 46 ++
>> arch/arm64/boot/dts/synaptics/sl2619-rdk.dts | 16 +
>> arch/arm64/boot/dts/synaptics/sl2619.dtsi | 44 +
>> .../boot/dts/synaptics/sl261x-rdk-common.dtsi | 135 ++++
>> drivers/clk/Kconfig | 1 +
>> drivers/clk/berlin/Kconfig | 34 +
>> drivers/clk/berlin/Makefile | 4 +
>> drivers/clk/berlin/clk-sl2610.c | 360 +++++++++
>> drivers/clk/berlin/sl-clk.c | 279 +++++++
>> drivers/clk/berlin/sl-clk.h | 31 +
>> drivers/clk/berlin/sl-sysmgr-clk.c | 241 ++++++
>> drivers/clk/berlin/sl-sysmgr-clk.h | 44 +
>> drivers/clk/berlin/sl2610-pll.c | 145 ++++
>> drivers/clk/berlin/sl2610-pll.h | 14 +
>> drivers/pinctrl/berlin/Kconfig | 16 +
>> drivers/pinctrl/berlin/Makefile | 1 +
>> drivers/pinctrl/berlin/berlin.c | 259 +++++-
>> drivers/pinctrl/berlin/berlin.h | 17 +-
>> drivers/pinctrl/berlin/pinctrl-sl2610.c | 759 ++++++++++++++++++
>> drivers/reset/Kconfig | 13 +
>> drivers/reset/Makefile | 1 +
>> drivers/reset/reset-sl2610.c | 224 ++++++
>> drivers/soc/Kconfig | 1 +
>> drivers/soc/Makefile | 1 +
>> drivers/soc/synaptics/Kconfig | 14 +
>> drivers/soc/synaptics/Makefile | 2 +
>> drivers/soc/synaptics/sl2610-syscon.c | 84 ++
>> include/dt-bindings/clock/syna,sl2610.h | 131 +++
>> include/dt-bindings/reset/syna,sl2610-reset.h | 80 ++
>> 41 files changed, 3771 insertions(+), 20 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/soc/synaptics/syna,sl2610-soc-syscon.yaml
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl2611-rdk.dts
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl2611.dtsi
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl2613-rdk.dts
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl2613.dtsi
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl2615-rdk.dts
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl2615.dtsi
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl2617-rdk.dts
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl2617.dtsi
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl2619-rdk.dts
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl2619.dtsi
>> create mode 100644 arch/arm64/boot/dts/synaptics/sl261x-rdk-common.dtsi
>> create mode 100644 drivers/clk/berlin/Kconfig
>> create mode 100644 drivers/clk/berlin/clk-sl2610.c
>> create mode 100644 drivers/clk/berlin/sl-clk.c
>> create mode 100644 drivers/clk/berlin/sl-clk.h
>> create mode 100644 drivers/clk/berlin/sl-sysmgr-clk.c
>> create mode 100644 drivers/clk/berlin/sl-sysmgr-clk.h
>> create mode 100644 drivers/clk/berlin/sl2610-pll.c
>> create mode 100644 drivers/clk/berlin/sl2610-pll.h
>> create mode 100644 drivers/pinctrl/berlin/pinctrl-sl2610.c
>> create mode 100644 drivers/reset/reset-sl2610.c
>> create mode 100644 drivers/soc/synaptics/Kconfig
>> create mode 100644 drivers/soc/synaptics/Makefile
>> create mode 100644 drivers/soc/synaptics/sl2610-syscon.c
>> create mode 100644 include/dt-bindings/clock/syna,sl2610.h
>> create mode 100644 include/dt-bindings/reset/syna,sl2610-reset.h
>>
>> --
>> 2.55.0
>>
>>
>
--
Richard Genoud, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-11-18 7:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 10:23 Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 01/13] arm64: kconfig: let ARCH_BERLIN cover Synaptics arm64 SoCs Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 02/13] pinctrl: berlin: use u16 instead of u8 for the offset Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 03/13] pinctrl: berlin: enable module build support Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 04/13] pinctrl: berlin: add optional pinconf support Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 05/13] dt-bindings: soc: synaptics: add SL2610 system controllers Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 06/13] soc: synaptics: add SL2610 system controller support Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 07/13] reset: add Synaptics SL2610 reset " Jisheng Zhang
2026-11-16 11:49 ` Philipp Zabel
2026-11-16 12:05 ` Philipp Zabel
2026-11-15 10:23 ` [PATCH v2 08/13] pinctrl: berlin: add Synaptics SL2610 pin " Jisheng Zhang
2026-11-16 12:08 ` Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 09/13] clk: berlin: add Synaptics clock controller helpers Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 10/13] clk: berlin: add Synaptics SL2610 clocks and PLLs Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 11/13] dt-bindings: arm: berlin: add Synaptics SL2610 SoCs and RDK boards Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 12/13] arm64: dts: synaptics: add SL2610 family SoCs Jisheng Zhang
2026-11-15 10:23 ` [PATCH v2 13/13] arm64: dts: synaptics: add SL2610 family RDK boards Jisheng Zhang
2026-11-16 12:06 ` [PATCH v2 00/13] arm64: add Synaptics SL2610 SoCs and " Jisheng Zhang
2026-11-18 7:54 ` Richard GENOUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26aa0b74-e3f8-4405-ab87-743f5f8ef197@bootlin.com \
--to=richard.genoud@bootlin.com \
--cc=bmasney+clk@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet+clk@baylibre.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®