mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] Fix usb controller properties on glymur
@ 2026-07-23 17:32 Krishna Kurapati
  2026-07-23 17:32 ` [PATCH 1/2] arm64: dts: qcom: glymur: Fix properties of usb_hs node Krishna Kurapati
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Krishna Kurapati @ 2026-07-23 17:32 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Krishna Kurapati

The Glymur usb-hs only controller is role-switch capable. Also all
controllers are wakeup capable. This series add these missing properties.

This series has only been compile tested.

Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
Krishna Kurapati (2):
      arm64: dts: qcom: glymur: Fix properties of usb_hs node
      arm64: dts: qcom: glymur: Configure USB controllers are wakeup-capable

 arch/arm64/boot/dts/qcom/glymur-crd.dtsi |  2 ++
 arch/arm64/boot/dts/qcom/glymur.dtsi     | 10 ++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)
---
base-commit: 9eebf259d5352b87080d67758f483583d9e763d7
change-id: 20260723-glymur-usb-fixes-5da82dc93827

Best regards,
--  
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/2] arm64: dts: qcom: glymur: Fix properties of usb_hs node
  2026-07-23 17:32 [PATCH 0/2] Fix usb controller properties on glymur Krishna Kurapati
@ 2026-07-23 17:32 ` Krishna Kurapati
  2026-07-23 20:08   ` Dmitry Baryshkov
  2026-07-28 12:01   ` Konrad Dybcio
  2026-07-23 17:32 ` [PATCH 2/2] arm64: dts: qcom: glymur: Configure USB controllers are wakeup-capable Krishna Kurapati
  2026-07-31  3:24 ` [PATCH 0/2] Fix usb controller properties on glymur Bjorn Andersson
  2 siblings, 2 replies; 8+ messages in thread
From: Krishna Kurapati @ 2026-07-23 17:32 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Krishna Kurapati

The High-speed only controller is DRD capable. Hence move the dr_mode
property to platform DTS and mark the controller as role switch capable.

While at it, since its high-speed only controller, disable pipe clock
requirement.

Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 2 ++
 arch/arm64/boot/dts/qcom/glymur.dtsi     | 5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
index c12808abbfe1..7731b29857bb 100644
--- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
@@ -1204,6 +1204,8 @@ &usb_1_qmpphy_out {
 };
 
 &usb_hs {
+	dr_mode = "host";
+
 	status = "okay";
 };
 
diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
index f32af66a3f1c..b9eb0fe8e413 100644
--- a/arch/arm64/boot/dts/qcom/glymur.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
@@ -4794,10 +4794,11 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			snps,dis_u2_susphy_quirk;
 			snps,dis_enblslpm_quirk;
 
-			dr_mode = "host";
-
 			maximum-speed = "high-speed";
 
+			qcom,select-utmi-as-pipe-clk;
+			usb-role-switch;
+
 			status = "disabled";
 		};
 

-- 
2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: glymur: Configure USB controllers are wakeup-capable
  2026-07-23 17:32 [PATCH 0/2] Fix usb controller properties on glymur Krishna Kurapati
  2026-07-23 17:32 ` [PATCH 1/2] arm64: dts: qcom: glymur: Fix properties of usb_hs node Krishna Kurapati
@ 2026-07-23 17:32 ` Krishna Kurapati
  2026-07-23 20:09   ` Dmitry Baryshkov
  2026-07-24  7:51   ` Konrad Dybcio
  2026-07-31  3:24 ` [PATCH 0/2] Fix usb controller properties on glymur Bjorn Andersson
  2 siblings, 2 replies; 8+ messages in thread
From: Krishna Kurapati @ 2026-07-23 17:32 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Krishna Kurapati

All USB controller on Glymur are wakeup-capable device. Add wakeup-source
property for each of them indicating the same.

Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/glymur.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
index b9eb0fe8e413..74692ac1a22b 100644
--- a/arch/arm64/boot/dts/qcom/glymur.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
@@ -4559,6 +4559,7 @@ usb_0: usb@a600000 {
 			snps,dis_enblslpm_quirk;
 
 			usb-role-switch;
+			wakeup-source;
 
 			status = "disabled";
 
@@ -4634,6 +4635,7 @@ usb_1: usb@a800000 {
 			snps,dis_enblslpm_quirk;
 
 			usb-role-switch;
+			wakeup-source;
 
 			status = "disabled";
 
@@ -4709,6 +4711,7 @@ usb_2: usb@a000000 {
 			snps,dis_enblslpm_quirk;
 
 			usb-role-switch;
+			wakeup-source;
 
 			status = "disabled";
 
@@ -4798,6 +4801,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 
 			qcom,select-utmi-as-pipe-clk;
 			usb-role-switch;
+			wakeup-source;
 
 			status = "disabled";
 		};
@@ -4869,6 +4873,7 @@ usb_mp: usb@a400000 {
 			snps,dis_enblslpm_quirk;
 
 			dr_mode = "host";
+			wakeup-source;
 
 			status = "disabled";
 		};

-- 
2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: glymur: Fix properties of usb_hs node
  2026-07-23 17:32 ` [PATCH 1/2] arm64: dts: qcom: glymur: Fix properties of usb_hs node Krishna Kurapati
@ 2026-07-23 20:08   ` Dmitry Baryshkov
  2026-07-28 12:01   ` Konrad Dybcio
  1 sibling, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2026-07-23 20:08 UTC (permalink / raw)
  To: Krishna Kurapati
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel

On Thu, Jul 23, 2026 at 11:02:25PM +0530, Krishna Kurapati wrote:
> The High-speed only controller is DRD capable. Hence move the dr_mode
> property to platform DTS and mark the controller as role switch capable.
> 
> While at it, since its high-speed only controller, disable pipe clock
> requirement.
> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 2 ++
>  arch/arm64/boot/dts/qcom/glymur.dtsi     | 5 +++--
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: glymur: Configure USB controllers are wakeup-capable
  2026-07-23 17:32 ` [PATCH 2/2] arm64: dts: qcom: glymur: Configure USB controllers are wakeup-capable Krishna Kurapati
@ 2026-07-23 20:09   ` Dmitry Baryshkov
  2026-07-24  7:51   ` Konrad Dybcio
  1 sibling, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2026-07-23 20:09 UTC (permalink / raw)
  To: Krishna Kurapati
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel

On Thu, Jul 23, 2026 at 11:02:26PM +0530, Krishna Kurapati wrote:
> All USB controller on Glymur are wakeup-capable device. Add wakeup-source
> property for each of them indicating the same.
> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/glymur.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: glymur: Configure USB controllers are wakeup-capable
  2026-07-23 17:32 ` [PATCH 2/2] arm64: dts: qcom: glymur: Configure USB controllers are wakeup-capable Krishna Kurapati
  2026-07-23 20:09   ` Dmitry Baryshkov
@ 2026-07-24  7:51   ` Konrad Dybcio
  1 sibling, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2026-07-24  7:51 UTC (permalink / raw)
  To: Krishna Kurapati, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 7/23/26 7:32 PM, Krishna Kurapati wrote:
> All USB controller on Glymur are wakeup-capable device. Add wakeup-source
> property for each of them indicating the same.
> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: glymur: Fix properties of usb_hs node
  2026-07-23 17:32 ` [PATCH 1/2] arm64: dts: qcom: glymur: Fix properties of usb_hs node Krishna Kurapati
  2026-07-23 20:08   ` Dmitry Baryshkov
@ 2026-07-28 12:01   ` Konrad Dybcio
  1 sibling, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2026-07-28 12:01 UTC (permalink / raw)
  To: Krishna Kurapati, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 7/23/26 7:32 PM, Krishna Kurapati wrote:
> The High-speed only controller is DRD capable. Hence move the dr_mode
> property to platform DTS and mark the controller as role switch capable.
> 
> While at it, since its high-speed only controller, disable pipe clock
> requirement.
> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] Fix usb controller properties on glymur
  2026-07-23 17:32 [PATCH 0/2] Fix usb controller properties on glymur Krishna Kurapati
  2026-07-23 17:32 ` [PATCH 1/2] arm64: dts: qcom: glymur: Fix properties of usb_hs node Krishna Kurapati
  2026-07-23 17:32 ` [PATCH 2/2] arm64: dts: qcom: glymur: Configure USB controllers are wakeup-capable Krishna Kurapati
@ 2026-07-31  3:24 ` Bjorn Andersson
  2 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2026-07-31  3:24 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Krishna Kurapati
  Cc: linux-arm-msm, devicetree, linux-kernel


On Thu, 23 Jul 2026 23:02:24 +0530, Krishna Kurapati wrote:
> The Glymur usb-hs only controller is role-switch capable. Also all
> controllers are wakeup capable. This series add these missing properties.
> 
> This series has only been compile tested.
> 
> 

Applied, thanks!

[1/2] arm64: dts: qcom: glymur: Fix properties of usb_hs node
      commit: e78c5e9d79e3c024e9b80ec067e62477c29aa29f
[2/2] arm64: dts: qcom: glymur: Configure USB controllers are wakeup-capable
      commit: 5ac32106d3c2ea94abd236fe3ad3897925640289

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-07-31  3:24 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-23 17:32 [PATCH 0/2] Fix usb controller properties on glymur Krishna Kurapati
2026-07-23 17:32 ` [PATCH 1/2] arm64: dts: qcom: glymur: Fix properties of usb_hs node Krishna Kurapati
2026-07-23 20:08   ` Dmitry Baryshkov
2026-07-28 12:01   ` Konrad Dybcio
2026-07-23 17:32 ` [PATCH 2/2] arm64: dts: qcom: glymur: Configure USB controllers are wakeup-capable Krishna Kurapati
2026-07-23 20:09   ` Dmitry Baryshkov
2026-07-24  7:51   ` Konrad Dybcio
2026-07-31  3:24 ` [PATCH 0/2] Fix usb controller properties on glymur Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®