From: Ian Abbott <abbotti@mev.co.uk>
To: Cheah Kok Cheong <thrust73@gmail.com>,
hsweeten@visionengravers.com, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: drivers: comedi_test: Set max input value for auto config
Date: Thu, 9 Feb 2017 12:28:42 +0000 [thread overview]
Message-ID: <271653cb-b0d9-dcb9-0bfb-e6282221cf02@mev.co.uk> (raw)
In-Reply-To: <1485532554-2520-1-git-send-email-thrust73@gmail.com>
On 27/01/17 15:55, Cheah Kok Cheong wrote:
> Currently user can input any value for amplitude and period.
> This patch set a sane max value for auto-configuration mode.
>
> For manual configuration mode, it is assumed this is taken care of
> by the COMEDI userspace tool since there's no limit set here from
> day one in the staging tree. If otherwise then maybe this can be
> looked at separately.
>
> Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
I don't think there is any need to limit these unless it results in
arithmetic overflow, since they only affect the fake sample data values
produced by the driver, not system performance.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2017-02-09 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 17:31 [PATCH] Staging: comedi: drivers: comedi_test: Add auto-configuration capability Cheah Kok Cheong
2017-01-27 15:55 ` [PATCH] Staging: comedi: drivers: comedi_test: Set max input value for auto config Cheah Kok Cheong
2017-02-09 12:28 ` Ian Abbott [this message]
2017-02-11 1:29 ` Cheah Kok Cheong
2017-02-08 7:42 ` [PATCH] Staging: comedi: drivers: comedi_test: Add auto-configuration capability Cheah Kok Cheong
2017-02-09 12:25 ` Ian Abbott
2017-02-11 0:53 ` Cheah Kok Cheong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=271653cb-b0d9-dcb9-0bfb-e6282221cf02@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thrust73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®