mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Shipei Qu <qu@darknavy.com>, Adam Radford <aradford@gmail.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	DARKNAVY <vr@darknavy.com>
Subject: Re: [PATCH v2] scsi: 3w-sas: validate request_id reported by controller
Date: Tue, 16 Dec 2025 07:18:51 +0100	[thread overview]
Message-ID: <27297f052a89a5e171bad743dd59f39a339ce126.camel@HansenPartnership.com> (raw)
In-Reply-To: <20251216060156.41320-1-qu@darknavy.com>

On Tue, 2025-12-16 at 14:01 +0800, Shipei Qu wrote:
> This issue was first reported via security@kernel.org. The kernel
> security team replied that, under the usual upstream threat model
> (only trusted PCIe/Thunderbolt devices are allowed to bind to such
> drivers), it should be treated as a normal robustness bug rather than
> a security issue, and asked us to send fixes to the relevant
> development lists. This email follows that guidance.

Realistically the same rationale goes for us as well.  Absent the
observation in the field of a problem device, we usually trust the
hardware, so unless you can find an actual device that exhibits the
problem this isn't really a fix for anything.

If the security@ list is happy that the existing trust model for
Thunderbolt/PCIe would prevent the attachment of malicious devices,
then I think we're also happy to take their word for it.  Even if
thunderbolt were a security problem, the fix would likely be in the
trust model not in all possible drivers.

Regards,

James Bottomley


  reply	other threads:[~2025-12-16  6:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16  6:01 Shipei Qu
2025-12-16  6:18 ` James Bottomley [this message]
2025-12-16  6:43   ` Shipei Qu
2025-12-16  7:03     ` James Bottomley
2025-12-20 14:00 ` kernel test robot
2025-12-20 14:34 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27297f052a89a5e171bad743dd59f39a339ce126.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=aradford@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=qu@darknavy.com \
    --cc=vr@darknavy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®