From: Jens Axboe <axboe@kernel.dk>
To: Rakesh Pandit <rakesh@tuxera.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.cz>,
linux-block@vger.kernel.org
Subject: Re: [PATCH V2] writeback: merge try_to_writeback_inodes_sb_nr() into caller
Date: Tue, 10 Oct 2017 08:15:02 -0600 [thread overview]
Message-ID: <2730ed85-a0a8-7da2-d91a-fe82fe215b75@kernel.dk> (raw)
In-Reply-To: <20171010094306.GA32628@dhcp-216.srv.tuxera.com>
On 10/10/2017 03:43 AM, Rakesh Pandit wrote:
> Hi Jens,
>
> On Mon, Oct 09, 2017 at 02:00:29PM +0200, Jan Kara wrote:
>> On Mon 09-10-17 13:34:41, Rakesh Pandit wrote:
>>> Since commit 925a6efb8ff0c ("Btrfs: stop using
>>> try_to_writeback_inodes_sb_nr to flush delalloc") this function hasn't
>>> been used outside so stop exporting it.
>>>
>>> In addition we merge it into try_to_writeback_inodes_sb() which is the
>>> only caller. Also change return type of try_to_writeback_inodes_sb to
>>> void as the only user ext4 doesn't care.
>>>
>>> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
>>
>> Looks good. You can add:
>>
>> Reviewed-by: Jan Kara <jack@suse.cz>
>>
>> Honza
>
> As there are many writeback related changes on your tree would you be
> okay queuing this up as well for-4.15 with above reviewed-by tag ?
>
> This should apply fine on your tree for-4.15.
>
> Let me know if that isn't okay.
That's fine, I'll queue it up.
--
Jens Axboe
prev parent reply other threads:[~2017-10-10 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 10:34 Rakesh Pandit
2017-10-09 12:00 ` Jan Kara
2017-10-10 9:43 ` Rakesh Pandit
2017-10-10 14:15 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2730ed85-a0a8-7da2-d91a-fe82fe215b75@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rakesh@tuxera.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®