From: yalin wang <yalin.wang2010@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
mark.rutland@arm.com, toshi.kani@hp.com, andre.przywara@arm.com,
michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
treding@nvidia.com, mingo@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC] arm64: ioremap: add ioremap_cache macro
Date: Wed, 14 Oct 2015 10:41:26 +0800 [thread overview]
Message-ID: <2731BCF2-D0C0-4B77-A59F-FF3AB2A725D6@gmail.com> (raw)
In-Reply-To: <20151013152011.GE11573@e104818-lin.cambridge.arm.com>
> On Oct 13, 2015, at 23:20, Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> On Tue, Oct 13, 2015 at 03:23:27PM +0100, Will Deacon wrote:
>> On Tue, Oct 13, 2015 at 03:10:55PM +0100, Catalin Marinas wrote:
>>> On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote:
>>>> Add ioremap_cache macro, because some code will test if this macro
>>>> is defined or not, and will generate a generric version if not defined,
>>>> for example, memremap.c do like this.
>>>>
>>>> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
>>>> ---
>>>> arch/arm64/include/asm/io.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h
>>>> index 44be1e0..d6b620c 100644
>>>> --- a/arch/arm64/include/asm/io.h
>>>> +++ b/arch/arm64/include/asm/io.h
>>>> @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size);
>>>> #define ioremap_wc(addr, size) __ioremap((addr), (size), __pgprot(PROT_NORMAL_NC))
>>>> #define ioremap_wt(addr, size) __ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE))
>>>> #define iounmap __iounmap
>>>> +#define ioremap_cache ioremap_cache
>>>
>>> Applied. Thanks.
>>
>> I'm not sure we want this. See:
>>
>> https://lkml.org/lkml/2015/10/9/699
>
> Thanks Will and Arnd, I missed this. Patch reverted.
>
i don’t understand why conflict with Dan Williams’ patch.
Dan Williams ’s patch also define ioremap_cache for arch ia64 & arch sh & arch xtensa ,
i see this :
# git show 92281dee825f
am i miss something?
Thanks
next prev parent reply other threads:[~2015-10-14 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 2:28 yalin wang
2015-10-13 14:10 ` Catalin Marinas
2015-10-13 14:23 ` Will Deacon
2015-10-13 15:20 ` Catalin Marinas
2015-10-14 2:41 ` yalin wang [this message]
2015-10-14 8:23 ` Arnd Bergmann
2015-10-14 12:01 ` yalin wang
2015-10-13 14:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2731BCF2-D0C0-4B77-A59F-FF3AB2A725D6@gmail.com \
--to=yalin.wang2010@gmail.com \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=mingo@kernel.org \
--cc=toshi.kani@hp.com \
--cc=treding@nvidia.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®