From: David Howells <dhowells@redhat.com>
To: Joep Duin <joepduin12@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: dhowells@redhat.com, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix MIC buffer sizing in selftest
Date: Fri, 21 Nov 2025 09:12:45 +0000 [thread overview]
Message-ID: <2735328.1763716365@warthog.procyon.org.uk> (raw)
In-Reply-To: <aR_spUmU7FswxA2Q@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > /* Generate a MIC generation request. */
> > - sg_init_one(sg, buf, 1024);
> > + sg_init_one(sg, buf, message_len);
> >
> > - ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, 1024,
> > - krb5->cksum_len, plain.len);
> > + ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, message_len,
> > + krb5->cksum_len, plain.len);
The buffer doesn't need to fit exactly, it just needs to be big enough to hold
the output produced, but it can be bigger.
David
prev parent reply other threads:[~2025-11-21 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 13:55 Joep Duin
2025-11-21 4:37 ` Herbert Xu
2025-11-21 9:12 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2735328.1763716365@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=joepduin12@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®