mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Joep Duin <joepduin12@gmail.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	165405982+joepduin@users.noreply.github.com,
	joepduin12@gmail.com, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] fix MIC buffer sizing in selftest
Date: Fri, 21 Nov 2025 12:37:57 +0800	[thread overview]
Message-ID: <aR_spUmU7FswxA2Q@gondor.apana.org.au> (raw)
In-Reply-To: <20251113135506.18594-1-joepduin12@gmail.com>

Joep Duin <joepduin12@gmail.com> wrote:
> From: Joep Duin <165405982+joepduin@users.noreply.github.com>
> 
> Signed-off-by: Joep Duin <joepduin12@gmail.com>
> ---
> crypto/krb5/selftest.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/crypto/krb5/selftest.c b/crypto/krb5/selftest.c
> index 4519c572d37e..82b2b6a3607d 100644
> --- a/crypto/krb5/selftest.c
> +++ b/crypto/krb5/selftest.c
> @@ -427,10 +427,10 @@ static int krb5_test_one_mic(const struct krb5_mic_test *test, void *buf)
>        memcpy(buf + offset, plain.data, plain.len);
> 
>        /* Generate a MIC generation request. */
> -       sg_init_one(sg, buf, 1024);
> +       sg_init_one(sg, buf, message_len);
> 
> -       ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, 1024,
> -                                 krb5->cksum_len, plain.len);
> +       ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, message_len,
> +                   krb5->cksum_len, plain.len);

I have no idea what you're trying to fix here.  Please explain
the problem.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2025-11-21  4:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 13:55 Joep Duin
2025-11-21  4:37 ` Herbert Xu [this message]
2025-11-21  9:12   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aR_spUmU7FswxA2Q@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=165405982+joepduin@users.noreply.github.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=joepduin12@gmail.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®