From: taoqi <taoqi10@huawei.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <davem@davemloft.net>, <liulongfang@huawei.com>,
<linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 3/4] crypto: hisilicon/sec2 - fix some cleanup issues
Date: Fri, 26 Jan 2024 16:40:39 +0800 [thread overview]
Message-ID: <273d30b3-edba-4f4c-8138-fe83dbfd83aa@huawei.com> (raw)
In-Reply-To: <ZbIry8M6yFUAr5oL@gondor.apana.org.au>
On 2024/1/25 17:37, Herbert Xu wrote:
> On Fri, Dec 29, 2023 at 02:44:20PM +0800, Qi Tao wrote:
>>
>> @@ -1371,7 +1371,7 @@ static int sec_skcipher_bd_fill_v3(struct sec_ctx *ctx, struct sec_req *req)
>> sec_sqe3->bd_param = cpu_to_le32(bd_param);
>>
>> sec_sqe3->c_len_ivin |= cpu_to_le32(c_req->c_len);
>> - sec_sqe3->tag = cpu_to_le64(req);
>> + sec_sqe3->tag = cpu_to_le64((unsigned long)(uintptr_t)req);
>
> Please explain why you're casting twice.
>
> Thanks,
I'm sorry. I made a mistake here. unsigned long and uintptr_t are the
same data type in linux kernel. The type cast is invalidly repeated
here. Can I just keep (unsigned long) one cast?
next prev parent reply other threads:[~2024-01-26 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 6:44 [PATCH v2 0/4] some updates and cleanups for hisilicon/sec2 Qi Tao
2023-12-29 6:44 ` [PATCH 1/4] crypto: hisilicon/sec2 - updates the sec DFX function register Qi Tao
2023-12-29 6:44 ` [PATCH 2/4] crypto: hisilicon/sec2 - modify nested macro call Qi Tao
2023-12-29 6:44 ` [PATCH 3/4] crypto: hisilicon/sec2 - fix some cleanup issues Qi Tao
2024-01-25 9:37 ` Herbert Xu
2024-01-26 8:40 ` taoqi [this message]
2024-01-26 8:54 ` Herbert Xu
2023-12-29 6:44 ` [PATCH 4/4] crypto: hisilicon/sec - remove unused parameter Qi Tao
2024-01-04 7:58 ` [PATCH v2 0/4] some updates and cleanups for hisilicon/sec2 liulongfang
2024-01-19 6:25 ` taoqi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=273d30b3-edba-4f4c-8138-fe83dbfd83aa@huawei.com \
--to=taoqi10@huawei.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liulongfang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®