From: wangyufei <wangyufei@vivo.com>
To: Kundan Kumar <kundan.kumar@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
open list <linux-kernel@vger.kernel.org>,
"open list:MEMORY MANAGEMENT - MISC" <linux-mm@kvack.org>,
"open list:PAGE CACHE" <linux-fsdevel@vger.kernel.org>
Cc: anuj20.g@samsung.com, hch@lst.de, bernd@bsbernd.com,
djwong@kernel.org, jack@suse.cz, opensource.kernel@vivo.com
Subject: Re: [RFC 0/1] writeback: add sysfs to config the number of writeback contexts
Date: Tue, 2 Sep 2025 19:19:20 +0800 [thread overview]
Message-ID: <275322fe-b8d7-4081-80cf-926874286ea9@vivo.com> (raw)
In-Reply-To: <77291508-cd85-4889-8502-73eb834e543c@samsung.com>
On 8/29/2025 4:59 PM, Kundan Kumar wrote:
> On 8/25/2025 5:59 PM, wangyufei wrote:
>> Hi everyone,
>>
>> We've been interested in this patch about parallelizing writeback [1]
>> and have been following its discussion and development. Our testing in
>> several application scenarios on mobile devices has shown significant
>> performance improvements.
>>
> Hi,
>
> Thanks for sharing this work.
>
> Could you clarify a few details about your test setup?
>
> - Which filesystem did you run these experiments on?
> - What were the specifics of the workload (number of threads, block size,
> I/O size)?
> - If you are using fio, can you please share the fio command.
> - How much RAM was available on the test system?
> - Can you share the performance improvement numbers you observed?
>
> That would help in understanding the impact of parallel writeback?
Hi Kundan,
Most of the time we tested this patch on mobile devices. The test
platform setup is shown as below:
- filesystem:F2FS
- system config:
Number of CPUs = 8
System RAM = 11G
- workload & fio:We used the same fio command as mentioned in your patch
fio command line:
fio --directory=/mnt --name=test --bs=4k --iodepth=1024 --rw=randwrite
--ioengine=io_uring --time_based=1 -runtime=60 --numjobs=8 --size=450M
--direct=0 --eta-interval=1 --eta-newline=1 --group_reporting
- Performance gains:
Base F2FS :973 MiB/s
Parallel Writeback F2FS :1237 MiB/s (+27%)
>
> I made similar modifications to dynamically configure the number of
> writeback threads in this experimental patch. Refer to patches 14 and 15:
> https://lore.kernel.org/all/20250807045706.2848-1-kundan.kumar@samsung.com/
> The key difference is that this change also enables a reduction in the
> number of writeback threads.
Thanks for sharing the patch. I have a few questions:
- The current approach freezes the filesystem and reallocates all
writeback_ctx structures. Could this introduce latency? In some cases, I
think the existing bdi_writeback_ctx structures could be reused instead.
- Are there other use cases for dynamic thread tuning besides
initialization and testing?
- What methods are used to test the stability of this function?
Finally, I would like to ask if there are any problems to be solved or
optimization directions worth discussing for the parallelizing
filesystem writeback?
Thanks,
yufei
prev parent reply other threads:[~2025-09-02 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250825123009epcas5p1573496e2cad2f58d22036493e5af03be@epcas5p1.samsung.com>
2025-08-25 12:29 ` wangyufei
2025-08-25 12:29 ` [RFC 1/1] " wangyufei
2025-08-25 14:46 ` [RFC 0/1] " David Hildenbrand
2025-08-25 16:15 ` Matthew Wilcox
2025-08-29 8:59 ` Kundan Kumar
2025-09-02 11:19 ` wangyufei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=275322fe-b8d7-4081-80cf-926874286ea9@vivo.com \
--to=wangyufei@vivo.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anuj20.g@samsung.com \
--cc=bernd@bsbernd.com \
--cc=david@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kundan.kumar@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=opensource.kernel@vivo.com \
--cc=rppt@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®