* [PATCH v1 1/1] serial: 8250_core: Use str_enabled_disabled() helper
@ 2022-10-17 17:16 Andy Shevchenko
2022-10-17 17:27 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2022-10-17 17:16 UTC (permalink / raw)
To: Greg Kroah-Hartman, Andy Shevchenko, Ilpo Järvinen,
linux-serial, linux-kernel
Cc: Jiri Slaby
Use str_enabled_disabled() helper instead of open coding the same.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/tty/serial/8250/8250_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 94fbf0add2ce..80a2fc2fbd4d 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -32,6 +32,7 @@
#include <linux/nmi.h>
#include <linux/mutex.h>
#include <linux/slab.h>
+#include <linux/string_helpers.h>
#include <linux/uaccess.h>
#include <linux/io.h>
#ifdef CONFIG_SPARC
@@ -1175,8 +1176,8 @@ static int __init serial8250_init(void)
serial8250_isa_init_ports();
- pr_info("Serial: 8250/16550 driver, %d ports, IRQ sharing %sabled\n",
- nr_uarts, share_irqs ? "en" : "dis");
+ pr_info("Serial: 8250/16550 driver, %d ports, IRQ sharing %s\n",
+ nr_uarts, str_enabled_disabled(share_irqs));
#ifdef CONFIG_SPARC
ret = sunserial_register_minors(&serial8250_reg, UART_NR);
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v1 1/1] serial: 8250_core: Use str_enabled_disabled() helper
2022-10-17 17:16 [PATCH v1 1/1] serial: 8250_core: Use str_enabled_disabled() helper Andy Shevchenko
@ 2022-10-17 17:27 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2022-10-17 17:27 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Greg Kroah-Hartman, linux-serial, LKML, Jiri Slaby
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
On Mon, 17 Oct 2022, Andy Shevchenko wrote:
> Use str_enabled_disabled() helper instead of open coding the same.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 94fbf0add2ce..80a2fc2fbd4d 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -32,6 +32,7 @@
> #include <linux/nmi.h>
> #include <linux/mutex.h>
> #include <linux/slab.h>
> +#include <linux/string_helpers.h>
> #include <linux/uaccess.h>
> #include <linux/io.h>
> #ifdef CONFIG_SPARC
> @@ -1175,8 +1176,8 @@ static int __init serial8250_init(void)
>
> serial8250_isa_init_ports();
>
> - pr_info("Serial: 8250/16550 driver, %d ports, IRQ sharing %sabled\n",
> - nr_uarts, share_irqs ? "en" : "dis");
> + pr_info("Serial: 8250/16550 driver, %d ports, IRQ sharing %s\n",
> + nr_uarts, str_enabled_disabled(share_irqs));
>
> #ifdef CONFIG_SPARC
> ret = sunserial_register_minors(&serial8250_reg, UART_NR);
>
Looks ok.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-17 17:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 17:16 [PATCH v1 1/1] serial: 8250_core: Use str_enabled_disabled() helper Andy Shevchenko
2022-10-17 17:27 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®