Re: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

["Rafael J. Wysocki" <rjw@rjwysocki.net>]

On Tuesday, December 17, 2013 12:25:18 PM Josh Triplett wrote:
> On Tue, Dec 17, 2013 at 05:35:46PM +0000, Moore, Robert wrote:
> > I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".
> 
> This is the version in the latest git tree for the Linux kernel.

Well, I guess that's something for Lv to look at, then.

Lv, we seem to have a divergence here, can you please see if we can fix it
shortly?

Rafael


> > > -----Original Message-----
> > > From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> > > Sent: Tuesday, December 17, 2013 1:22 AM
> > > To: linux-kernel@vger.kernel.org
> > > Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> > > acpi@vger.kernel.org; josh@joshtriplett.org; devel@acpica.org
> > > Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> > > utstate.c
> > > 
> > > Include appropriate header file acutils.h in acpica/utstate.c because
> > > function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> > > in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> > > condition of ACPI_FUTURE_USAGE.
> > > 
> > > This eliminates the following warning in utstate.c:
> > > drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> > > ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> > > 
> > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > ---
> > >  drivers/acpi/acpica/utstate.c |    3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> > > index 03c4c2f..0920d23 100644
> > > --- a/drivers/acpi/acpica/utstate.c
> > > +++ b/drivers/acpi/acpica/utstate.c
> > > @@ -43,6 +43,7 @@
> > > 
> > >  #include <acpi/acpi.h>
> > >  #include "accommon.h"
> > > +#include "acutils.h"
> > > 
> > >  #define _COMPONENT          ACPI_UTILITIES
> > >  ACPI_MODULE_NAME("utstate")
> > > @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
> > >   * DESCRIPTION: Create a new state and push it
> > >   *
> > > 
> > > **************************************************************************
> > > ****/
> > > +#ifdef  ACPI_FUTURE_USAGE
> > >  acpi_status
> > >  acpi_ut_create_pkg_state_and_push(void *internal_object,
> > >  				  void *external_object,
> > > @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
> > >  	acpi_ut_push_generic_state(state_list, state);
> > >  	return (AE_OK);
> > >  }
> > > +#endif
> > > 
> > > 
> > > /*************************************************************************
> > > ******
> > >   *
> > > --
> > > 1.7.9.5
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.