mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, josh@joshtriplett.org
Subject: Re: [PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c
Date: Mon, 06 Jan 2014 00:30:20 +0100	[thread overview]
Message-ID: <6441094.4QZhMcC2S0@vostro.rjw.lan> (raw)
In-Reply-To: <c676af6619fc5a84208740bfc7edcf56bb78ed4e.1387271324.git.rashika.kheria@gmail.com>

On Tuesday, December 17, 2013 02:43:05 PM Rashika Kheria wrote:
> Marks the function acpi_table_checksum() as static in osl.c
> because it is not used outside this file.
> 
> This eliminates the following warning in osl.c:
> drivers/acpi/osl.c:547:11: warning: no previous prototype for
> ‘acpi_table_checksum’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

I've queued up patches [1-4/11] and [7-10/11] for 3.14.

I've skipped patches [5-6/11], because the general rule for ACPICA material is
that it should go through ACPICA upstream, so please submit those patches to
Bob/Lv.

I'll send a reply to patch [11/11] in a while.

Thanks!

> ---
>  drivers/acpi/osl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 54a20ff..1f4c104 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -544,7 +544,7 @@ static u64 acpi_tables_addr;
>  static int all_tables_size;
>  
>  /* Copied from acpica/tbutils.c:acpi_tb_checksum() */
> -u8 __init acpi_table_checksum(u8 *buffer, u32 length)
> +static u8 __init acpi_table_checksum(u8 *buffer, u32 length)
>  {
>  	u8 sum = 0;
>  	u8 *end = buffer + length;
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

      parent reply	other threads:[~2014-01-05 23:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  9:11 Rashika Kheria
2013-12-17  9:15 ` [PATCH 02/11] drivers: acpi: Include appropriate header file in nvs.c Rashika Kheria
2013-12-17  9:16 ` [PATCH 03/11] drivers: acpi: Mark the function acpi_ec_add_debugfs() as static in ec_sys.c Rashika Kheria
2013-12-17  9:18 ` [PATCH 04/11] drivers: acpi: Include appropriate header file in pci_slot.c Rashika Kheria
2013-12-17  9:21 ` [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c Rashika Kheria
2013-12-17 17:35   ` Moore, Robert
2013-12-17 20:25     ` Josh Triplett
2013-12-18  1:08       ` Rafael J. Wysocki
2013-12-18  6:17     ` Zheng, Lv
2013-12-30 20:50       ` Josh Triplett
2013-12-17  9:24 ` [PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c Rashika Kheria
2013-12-18  6:31   ` Zheng, Lv
2013-12-17  9:28 ` [PATCH 07/11] drivers: acpi: Include appropriate header file in pci_link.c Rashika Kheria
2013-12-17  9:30 ` [PATCH 08/11] drivers: acpi: Include appropriate header file in dock.c Rashika Kheria
2013-12-17  9:32 ` [PATCH 09/11] drivers: acpi: Remove unused function in ec.c and add prototype declaration in header file internal.h Rashika Kheria
2013-12-17  9:34 ` [PATCH 10/11] drivers: acpi: Include appropriate header file in proc.c Rashika Kheria
2013-12-17  9:36 ` [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h Rashika Kheria
2014-01-05 23:33   ` Rafael J. Wysocki
2014-01-06  3:28     ` Josh Triplett
2014-01-06 11:17       ` Rafael J. Wysocki
2014-01-05 23:30 ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6441094.4QZhMcC2S0@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=josh@joshtriplett.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rashika.kheria@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®