From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Stratos Karafotis <stratosk@semaphore.gr>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cpufreq: powernow-k8: Suppress checkpatch warnings
Date: Tue, 20 May 2014 01:22:12 +0200 [thread overview]
Message-ID: <2759682.X7CU1JTh4P@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohponF4KKjq5JwTSjeHKPfyfvi=2Qpv8+6NNODPO1DxDVrvQ@mail.gmail.com>
On Monday, May 12, 2014 09:52:06 AM Viresh Kumar wrote:
> On 11 May 2014 22:56, Stratos Karafotis <stratosk@semaphore.gr> wrote:
> > Suppress the following checkpatch.pl warnings:
> >
> > - WARNING: Prefer pr_err(... to printk(KERN_ERR ...
> > - WARNING: Prefer pr_info(... to printk(KERN_INFO ...
> > - WARNING: Prefer pr_warn(... to printk(KERN_WARNING ...
> > - WARNING: quoted string split across lines
> > - WARNING: please, no spaces at the start of a line
> >
> > Also, define the pr_fmt macro instead of PFX for the module name.
> >
> > Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
Queued up for 3.16, thanks!
> > ---
> >
> > Changes v1 -> v2
> > - Use pr_err_once instead of printk_once
> > - Change missing_pss_msg to macro (because pr_err_once
> > doesn't compile otherwise)
> > - Put one pr_err message in a single line instead of two
> > - Ignore "line over 80 characters" warnings
> > - Change the word "Fix" in the subject of the patch to
> > "Suppress" as the patch doesn't really fix anything
> >
> > drivers/cpufreq/powernow-k8.c | 180 +++++++++++++++++-------------------------
> > drivers/cpufreq/powernow-k8.h | 2 +-
> > 2 files changed, 74 insertions(+), 108 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2014-05-19 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 17:26 Stratos Karafotis
2014-05-12 4:22 ` Viresh Kumar
2014-05-19 23:22 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2759682.X7CU1JTh4P@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=stratosk@semaphore.gr \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome