From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc: don't build vm_numa_stat_key if CONFIG_NUMA=n
Date: Mon, 29 Jun 2026 12:08:47 +0100 [thread overview]
Message-ID: <276820f5-76fe-4e6b-b1b3-d9235d097411@codethink.co.uk> (raw)
In-Reply-To: <20260624192742.afbd255b97d82ecfe7e11e17@linux-foundation.org>
On 25/06/2026 03:27, Andrew Morton wrote:
> On Thu, 18 Jun 2026 11:06:14 +0100 Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
>> The vm_numa_stat_key is only exported if CONFIG_NUMA is set,
>> so avoid the following warning by guarding it in an #ifdef
>> on CONFIG_NUMA:
>>
>> mm/page_alloc.c:165:1: warning: symbol 'vm_numa_stat_key' was not declared. Should it be static?
>>
>> ...
>>
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -162,7 +162,9 @@ DEFINE_PER_CPU(int, numa_node);
>> EXPORT_PER_CPU_SYMBOL(numa_node);
>> #endif
>>
>> +#ifdef CONFIG_NUMA
>> DEFINE_STATIC_KEY_TRUE(vm_numa_stat_key);
>> +#endif
>>
>> #ifdef CONFIG_HAVE_MEMORYLESS_NODES
>> /*
>
> It might be tidier to move this into mm/vmstat.c, around line 38?
Is it worth sending a version of the patch?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
prev parent reply other threads:[~2026-06-29 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 10:06 Ben Dooks
2026-06-18 18:09 ` Johannes Weiner
2026-06-18 19:08 ` Zi Yan
2026-06-19 0:10 ` SeongJae Park
2026-06-25 2:27 ` Andrew Morton
2026-06-29 11:08 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=276820f5-76fe-4e6b-b1b3-d9235d097411@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®