* [PATCH] soc: qcom: use assign_bit() where applicable
@ 2026-09-18 14:18 Peng Fan (OSS)
2026-09-21 8:04 ` Konrad Dybcio
2026-09-21 12:12 ` Abel Vesa
0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan (OSS) @ 2026-09-18 14:18 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa
Cc: linux-kernel, Peng Fan, linux-arm-msm
From: Peng Fan <peng.fan@nxp.com>
Convert open-coded if/else with set_bit/clear_bit and their
non-atomic __set_bit/__clear_bit variants to the assign_bit/__assign_bit
API.
Done with Coccinelle semantic patch:
// set_bit -> clear_bit => assign_bit
@@
expression cond, bit, addr;
@@
-if (cond)
- set_bit(bit, addr);
-else
- clear_bit(bit, addr);
+assign_bit(bit, addr, cond);
// clear_bit -> set_bit => assign_bit
@@
expression cond, bit, addr;
@@
-if (cond)
- clear_bit(bit, addr);
-else
- set_bit(bit, addr);
+assign_bit(bit, addr, !cond);
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/soc/qcom/smp2p.c | 10 ++--------
drivers/soc/qcom/smsm.c | 16 ++++------------
2 files changed, 6 insertions(+), 20 deletions(-)
diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
index 3104e31f91c9..01b8580c9f27 100644
--- a/drivers/soc/qcom/smp2p.c
+++ b/drivers/soc/qcom/smp2p.c
@@ -411,15 +411,9 @@ static int smp2p_set_irq_type(struct irq_data *irqd, unsigned int type)
if (!(type & IRQ_TYPE_EDGE_BOTH))
return -EINVAL;
- if (type & IRQ_TYPE_EDGE_RISING)
- set_bit(irq, entry->irq_rising);
- else
- clear_bit(irq, entry->irq_rising);
+ assign_bit(irq, entry->irq_rising, type & IRQ_TYPE_EDGE_RISING);
- if (type & IRQ_TYPE_EDGE_FALLING)
- set_bit(irq, entry->irq_falling);
- else
- clear_bit(irq, entry->irq_falling);
+ assign_bit(irq, entry->irq_falling, type & IRQ_TYPE_EDGE_FALLING);
return 0;
}
diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c
index ac3c85a2597a..bb487bf6bf03 100644
--- a/drivers/soc/qcom/smsm.c
+++ b/drivers/soc/qcom/smsm.c
@@ -277,10 +277,8 @@ static void smsm_unmask_irq(struct irq_data *irqd)
u32 val;
/* Make sure our last cached state is up-to-date */
- if (readl(entry->remote_state) & BIT(irq))
- set_bit(irq, &entry->last_value);
- else
- clear_bit(irq, &entry->last_value);
+ assign_bit(irq, &entry->last_value,
+ readl(entry->remote_state) & BIT(irq));
set_bit(irq, entry->irq_enabled);
@@ -304,15 +302,9 @@ static int smsm_set_irq_type(struct irq_data *irqd, unsigned int type)
if (!(type & IRQ_TYPE_EDGE_BOTH))
return -EINVAL;
- if (type & IRQ_TYPE_EDGE_RISING)
- set_bit(irq, entry->irq_rising);
- else
- clear_bit(irq, entry->irq_rising);
+ assign_bit(irq, entry->irq_rising, type & IRQ_TYPE_EDGE_RISING);
- if (type & IRQ_TYPE_EDGE_FALLING)
- set_bit(irq, entry->irq_falling);
- else
- clear_bit(irq, entry->irq_falling);
+ assign_bit(irq, entry->irq_falling, type & IRQ_TYPE_EDGE_FALLING);
return 0;
}
--
2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: use assign_bit() where applicable
2026-09-18 14:18 [PATCH] soc: qcom: use assign_bit() where applicable Peng Fan (OSS)
@ 2026-09-21 8:04 ` Konrad Dybcio
2026-09-21 12:12 ` Abel Vesa
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-09-21 8:04 UTC (permalink / raw)
To: Peng Fan (OSS), Bjorn Andersson, Konrad Dybcio, Abel Vesa
Cc: linux-kernel, Peng Fan, linux-arm-msm
On 9/18/26 4:18 PM, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert open-coded if/else with set_bit/clear_bit and their
> non-atomic __set_bit/__clear_bit variants to the assign_bit/__assign_bit
> API.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: use assign_bit() where applicable
2026-09-18 14:18 [PATCH] soc: qcom: use assign_bit() where applicable Peng Fan (OSS)
2026-09-21 8:04 ` Konrad Dybcio
@ 2026-09-21 12:12 ` Abel Vesa
1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2026-09-21 12:12 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, linux-kernel,
Peng Fan, linux-arm-msm
On 26-09-18 22:18:32, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert open-coded if/else with set_bit/clear_bit and their
> non-atomic __set_bit/__clear_bit variants to the assign_bit/__assign_bit
> API.
>
> Done with Coccinelle semantic patch:
> // set_bit -> clear_bit => assign_bit
>
> @@
> expression cond, bit, addr;
> @@
>
> -if (cond)
> - set_bit(bit, addr);
> -else
> - clear_bit(bit, addr);
> +assign_bit(bit, addr, cond);
>
> // clear_bit -> set_bit => assign_bit
>
> @@
> expression cond, bit, addr;
> @@
>
> -if (cond)
> - clear_bit(bit, addr);
> -else
> - set_bit(bit, addr);
> +assign_bit(bit, addr, !cond);
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-21 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-18 14:18 [PATCH] soc: qcom: use assign_bit() where applicable Peng Fan (OSS)
2026-09-21 8:04 ` Konrad Dybcio
2026-09-21 12:12 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®