* [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe() @ 2020-04-04 18:45 ` Markus Elfring 2020-04-04 21:40 ` Dmitry Osipenko 2020-04-06 0:00 ` [PATCH] " Chanwoo Choi 0 siblings, 2 replies; 5+ messages in thread From: Markus Elfring @ 2020-04-04 18:45 UTC (permalink / raw) To: linux-tegra, linux-pm, Chanwoo Choi, Dmitry Osipenko, Jonathan Hunter, Kyungmin Park, MyungJoo Ham, Thierry Reding Cc: LKML, kernel-janitors, Tang Bin From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 4 Apr 2020 20:34:02 +0200 The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/devfreq/tegra30-devfreq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index 28b2c7ca416e..93e6f4b25b04 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -807,10 +807,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) } err = platform_get_irq(pdev, 0); - if (err < 0) { - dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err); + if (err < 0) return err; - } + tegra->irq = err; irq_set_status_flags(tegra->irq, IRQ_NOAUTOEN); -- 2.26.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe() 2020-04-04 18:45 ` [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe() Markus Elfring @ 2020-04-04 21:40 ` Dmitry Osipenko 2020-04-05 6:00 ` Markus Elfring 2020-04-06 0:00 ` [PATCH] " Chanwoo Choi 1 sibling, 1 reply; 5+ messages in thread From: Dmitry Osipenko @ 2020-04-04 21:40 UTC (permalink / raw) To: Markus Elfring, linux-tegra, linux-pm, Chanwoo Choi, Jonathan Hunter, Kyungmin Park, MyungJoo Ham, Thierry Reding Cc: LKML, kernel-janitors, Tang Bin 04.04.2020 21:45, Markus Elfring пишет: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 4 Apr 2020 20:34:02 +0200 > > The function “platform_get_irq” can log an error already. > Thus omit a redundant message for the exception handling in the > calling function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/devfreq/tegra30-devfreq.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 28b2c7ca416e..93e6f4b25b04 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -807,10 +807,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > } > > err = platform_get_irq(pdev, 0); > - if (err < 0) { > - dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err); > + if (err < 0) > return err; > - } > + > tegra->irq = err; > > irq_set_status_flags(tegra->irq, IRQ_NOAUTOEN); > -- > 2.26.0 > Thanks, Reviewed-by: Dmitry Osipenko <digetx@gmail.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe() 2020-04-04 21:40 ` Dmitry Osipenko @ 2020-04-05 6:00 ` Markus Elfring 2020-04-05 13:50 ` Dmitry Osipenko 0 siblings, 1 reply; 5+ messages in thread From: Markus Elfring @ 2020-04-05 6:00 UTC (permalink / raw) To: Dmitry Osipenko, linux-tegra, linux-pm, Chanwoo Choi, Jonathan Hunter, Kyungmin Park, MyungJoo Ham, Thierry Reding Cc: LKML, kernel-janitors, Tang Bin > Reviewed-by: Dmitry Osipenko <digetx@gmail.com> Thanks for your positive feedback. Will the logging of error codes need any more clarification around such function calls? Regards, Markus ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe() 2020-04-05 6:00 ` Markus Elfring @ 2020-04-05 13:50 ` Dmitry Osipenko 0 siblings, 0 replies; 5+ messages in thread From: Dmitry Osipenko @ 2020-04-05 13:50 UTC (permalink / raw) To: Markus Elfring, linux-tegra, linux-pm, Chanwoo Choi, Jonathan Hunter, Kyungmin Park, MyungJoo Ham, Thierry Reding Cc: LKML, kernel-janitors, Tang Bin 05.04.2020 09:00, Markus Elfring пишет: >> Reviewed-by: Dmitry Osipenko <digetx@gmail.com> > > Thanks for your positive feedback. > > Will the logging of error codes need any more clarification > around such function calls? In general no, but it could be different for some (more complex) drivers. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe() 2020-04-04 18:45 ` [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe() Markus Elfring 2020-04-04 21:40 ` Dmitry Osipenko @ 2020-04-06 0:00 ` Chanwoo Choi 1 sibling, 0 replies; 5+ messages in thread From: Chanwoo Choi @ 2020-04-06 0:00 UTC (permalink / raw) To: Markus Elfring, linux-tegra, linux-pm, Dmitry Osipenko, Jonathan Hunter, Kyungmin Park, MyungJoo Ham, Thierry Reding Cc: LKML, kernel-janitors, Tang Bin On 4/5/20 3:45 AM, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 4 Apr 2020 20:34:02 +0200 > > The function “platform_get_irq” can log an error already. > Thus omit a redundant message for the exception handling in the > calling function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/devfreq/tegra30-devfreq.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 28b2c7ca416e..93e6f4b25b04 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -807,10 +807,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > } > > err = platform_get_irq(pdev, 0); > - if (err < 0) { > - dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err); > + if (err < 0) > return err; > - } > + > tegra->irq = err; > > irq_set_status_flags(tegra->irq, IRQ_NOAUTOEN); > -- > 2.26.0 > > > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-05 23:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200404184602epcas1p1e0188779ade7c393f9e37a4757e1b6cc@epcas1p1.samsung.com>
2020-04-04 18:45 ` [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe() Markus Elfring
2020-04-04 21:40 ` Dmitry Osipenko
2020-04-05 6:00 ` Markus Elfring
2020-04-05 13:50 ` Dmitry Osipenko
2020-04-06 0:00 ` [PATCH] " Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®