* [PATCH v1] fusion: mptctl: Use min macro
@ 2024-08-27 11:39 Yan Zhen
2024-08-31 12:19 ` David Laight
0 siblings, 1 reply; 2+ messages in thread
From: Yan Zhen @ 2024-08-27 11:39 UTC (permalink / raw)
To: sathya.prakash, sreekanth.reddy, suganath-prabu.subramani
Cc: MPT-FusionLinux.pdl, linux-scsi, linux-kernel, opensource.kernel,
Yan Zhen
Using the real macro is usually more intuitive and readable,
When the original file is guaranteed to contain the minmax.h header file
and compile correctly.
Signed-off-by: Yan Zhen <yanzhen@vivo.com>
---
drivers/message/fusion/mptctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
index 9f3999750..17798edf7 100644
--- a/drivers/message/fusion/mptctl.c
+++ b/drivers/message/fusion/mptctl.c
@@ -1609,7 +1609,7 @@ mptctl_eventreport (MPT_ADAPTER *ioc, unsigned long arg)
maxEvents = numBytes/sizeof(MPT_IOCTL_EVENTS);
- max = MPTCTL_EVENT_LOG_SIZE < maxEvents ? MPTCTL_EVENT_LOG_SIZE : maxEvents;
+ max = min(MPTCTL_EVENT_LOG_SIZE, maxEvents);
/* If fewer than 1 event is requested, there must have
* been some type of error.
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH v1] fusion: mptctl: Use min macro
2024-08-27 11:39 [PATCH v1] fusion: mptctl: Use min macro Yan Zhen
@ 2024-08-31 12:19 ` David Laight
0 siblings, 0 replies; 2+ messages in thread
From: David Laight @ 2024-08-31 12:19 UTC (permalink / raw)
To: 'Yan Zhen',
sathya.prakash, sreekanth.reddy, suganath-prabu.subramani
Cc: MPT-FusionLinux.pdl, linux-scsi, linux-kernel, opensource.kernel
From: Yan Zhen
> Sent: 27 August 2024 12:39
>
> Using the real macro is usually more intuitive and readable,
> When the original file is guaranteed to contain the minmax.h header file
> and compile correctly.
>
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
> ---
> drivers/message/fusion/mptctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
> index 9f3999750..17798edf7 100644
> --- a/drivers/message/fusion/mptctl.c
> +++ b/drivers/message/fusion/mptctl.c
> @@ -1609,7 +1609,7 @@ mptctl_eventreport (MPT_ADAPTER *ioc, unsigned long arg)
> maxEvents = numBytes/sizeof(MPT_IOCTL_EVENTS);
>
>
> - max = MPTCTL_EVENT_LOG_SIZE < maxEvents ? MPTCTL_EVENT_LOG_SIZE : maxEvents;
> + max = min(MPTCTL_EVENT_LOG_SIZE, maxEvents);
IMHO the arguments should be swapped.
min(variable, CONSTANT);
is better.
David.
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-31 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-27 11:39 [PATCH v1] fusion: mptctl: Use min macro Yan Zhen
2024-08-31 12:19 ` David Laight
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®