mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994
@ 2023-03-05 12:24 Krzysztof Kozlowski
  2023-03-06 10:46 ` Konrad Dybcio
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-05 12:24 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Kathiravan T, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
TXT to DT schema:

  apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]

Fixes: f935a752f229 ("dt-bindings: soc: qcom: smd-rpm: Convert binding to YAML schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
index 16fd67c0bd1f..3580b209cd4a 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
@@ -40,6 +40,7 @@ properties:
       - qcom,rpm-msm8953
       - qcom,rpm-msm8974
       - qcom,rpm-msm8976
+      - qcom,rpm-msm8994
       - qcom,rpm-msm8996
       - qcom,rpm-msm8998
       - qcom,rpm-sdm660
@@ -84,6 +85,7 @@ if:
           - qcom,rpm-msm8974
           - qcom,rpm-msm8976
           - qcom,rpm-msm8953
+          - qcom,rpm-msm8994
 then:
   properties:
     qcom,glink-channels: false
-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994
  2023-03-05 12:24 [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994 Krzysztof Kozlowski
@ 2023-03-06 10:46 ` Konrad Dybcio
  2023-03-07 19:48 ` Petr Vorel
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-03-06 10:46 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, Kathiravan T, linux-arm-msm, devicetree,
	linux-kernel



On 5.03.2023 13:24, Krzysztof Kozlowski wrote:
> Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
> TXT to DT schema:
> 
>   apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]
> 
> Fixes: f935a752f229 ("dt-bindings: soc: qcom: smd-rpm: Convert binding to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
It's funny how it was used in the dt in like 2016 but only added
to the driver in 2020..

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> index 16fd67c0bd1f..3580b209cd4a 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> @@ -40,6 +40,7 @@ properties:
>        - qcom,rpm-msm8953
>        - qcom,rpm-msm8974
>        - qcom,rpm-msm8976
> +      - qcom,rpm-msm8994
>        - qcom,rpm-msm8996
>        - qcom,rpm-msm8998
>        - qcom,rpm-sdm660
> @@ -84,6 +85,7 @@ if:
>            - qcom,rpm-msm8974
>            - qcom,rpm-msm8976
>            - qcom,rpm-msm8953
> +          - qcom,rpm-msm8994
>  then:
>    properties:
>      qcom,glink-channels: false

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994
  2023-03-05 12:24 [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994 Krzysztof Kozlowski
  2023-03-06 10:46 ` Konrad Dybcio
@ 2023-03-07 19:48 ` Petr Vorel
  2023-03-08  8:39   ` Krzysztof Kozlowski
  2023-03-08 22:19 ` Rob Herring
  2023-03-22 14:45 ` Bjorn Andersson
  3 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2023-03-07 19:48 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Kathiravan T, linux-arm-msm, devicetree,
	linux-kernel

Hi all,

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994
  2023-03-07 19:48 ` Petr Vorel
@ 2023-03-08  8:39   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-08  8:39 UTC (permalink / raw)
  To: Petr Vorel
  Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Kathiravan T, linux-arm-msm, devicetree,
	linux-kernel

On 07/03/2023 20:48, Petr Vorel wrote:
> Hi all,
> 
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

What did you review?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994
  2023-03-05 12:24 [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994 Krzysztof Kozlowski
  2023-03-06 10:46 ` Konrad Dybcio
  2023-03-07 19:48 ` Petr Vorel
@ 2023-03-08 22:19 ` Rob Herring
  2023-03-22 14:45 ` Bjorn Andersson
  3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2023-03-08 22:19 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Konrad Dybcio, Kathiravan T, Bjorn Andersson, Rob Herring,
	devicetree, Krzysztof Kozlowski, Andy Gross, linux-arm-msm,
	linux-kernel


On Sun, 05 Mar 2023 13:24:28 +0100, Krzysztof Kozlowski wrote:
> Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
> TXT to DT schema:
> 
>   apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]
> 
> Fixes: f935a752f229 ("dt-bindings: soc: qcom: smd-rpm: Convert binding to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994
  2023-03-05 12:24 [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994 Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2023-03-08 22:19 ` Rob Herring
@ 2023-03-22 14:45 ` Bjorn Andersson
  3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-03-22 14:45 UTC (permalink / raw)
  To: Krzysztof Kozlowski, devicetree, Krzysztof Kozlowski, Andy Gross,
	linux-kernel, linux-arm-msm, Konrad Dybcio, Kathiravan T,
	Rob Herring

On Sun, 5 Mar 2023 13:24:28 +0100, Krzysztof Kozlowski wrote:
> Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
> TXT to DT schema:
> 
>   apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]
> 
> 

Applied, thanks!

[1/1] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994
      commit: 34d84c3b0f63978efcb5136a6fd2e7e9d889da70

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-03-22 14:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-05 12:24 [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994 Krzysztof Kozlowski
2023-03-06 10:46 ` Konrad Dybcio
2023-03-07 19:48 ` Petr Vorel
2023-03-08  8:39   ` Krzysztof Kozlowski
2023-03-08 22:19 ` Rob Herring
2023-03-22 14:45 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®