[PATCH] mac80211: update outdated comment

[PATCH] mac80211: update outdated comment

[kexinsun]

The function ieee80211_start_scan() was refactored and replaced by
__ieee80211_start_scan() in commit f3b85252f081 ("mac80211: fix scan
races and rework scanning"). Update the comment in
ieee80211_tx_h_check_assoc() accordingly.

Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
---
 net/mac80211/tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 8cdbd417d7be..85c48b42474c 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -288,7 +288,7 @@ ieee80211_tx_h_check_assoc(struct ieee80211_tx_data *tx)
 		 * sent and we should not get here, but if we do
 		 * nonetheless, drop them to avoid sending them
 		 * off-channel. See the link below and
-		 * ieee80211_start_scan() for more.
+		 * __ieee80211_start_scan() for more.
 		 *
 		 * http://article.gmane.org/gmane.linux.kernel.wireless.general/30089
 		 */
-- 
2.25.1

Re: [PATCH] mac80211: update outdated comment

[Lachlan Hodges]

On Tue, Feb 24, 2026 at 10:15:48AM +0800, kexinsun wrote:
> The function ieee80211_start_scan() was refactored and replaced by
> __ieee80211_start_scan() in commit f3b85252f081 ("mac80211: fix scan
> races and rework scanning"). Update the comment in
> ieee80211_tx_h_check_assoc() accordingly.
> 
> Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
> ---
>  net/mac80211/tx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index 8cdbd417d7be..85c48b42474c 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -288,7 +288,7 @@ ieee80211_tx_h_check_assoc(struct ieee80211_tx_data *tx)
>  		 * sent and we should not get here, but if we do
>  		 * nonetheless, drop them to avoid sending them
>  		 * off-channel. See the link below and
> -		 * ieee80211_start_scan() for more.
> +		 * __ieee80211_start_scan() for more.
>  		 *
>  		 * http://article.gmane.org/gmane.linux.kernel.wireless.general/30089

Might be good to remove that link aswell and update the comment? Looks
to be dead.

lachlan 

Re: [PATCH] mac80211: update outdated comment

[Johannes Berg]

On Thu, 2026-02-26 at 21:57 +1100, Lachlan Hodges wrote:
> On Tue, Feb 24, 2026 at 10:15:48AM +0800, kexinsun wrote:
> > The function ieee80211_start_scan() was refactored and replaced by
> > __ieee80211_start_scan() in commit f3b85252f081 ("mac80211: fix scan
> > races and rework scanning"). Update the comment in
> > ieee80211_tx_h_check_assoc() accordingly.
> > 
> > Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
> > ---
> >  net/mac80211/tx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> > index 8cdbd417d7be..85c48b42474c 100644
> > --- a/net/mac80211/tx.c
> > +++ b/net/mac80211/tx.c
> > @@ -288,7 +288,7 @@ ieee80211_tx_h_check_assoc(struct ieee80211_tx_data *tx)
> >  		 * sent and we should not get here, but if we do
> >  		 * nonetheless, drop them to avoid sending them
> >  		 * off-channel. See the link below and
> > -		 * ieee80211_start_scan() for more.
> > +		 * __ieee80211_start_scan() for more.
> >  		 *
> >  		 * http://article.gmane.org/gmane.linux.kernel.wireless.general/30089
> 
> Might be good to remove that link aswell and update the comment? Looks
> to be dead.

Hm, yeah, I can't say what this link was now.

I did find where it came from though:
https://lore.kernel.org/all/1237368810.5100.15.camel@johannes.local/

I suspect that maybe it was meant to point to
https://lore.kernel.org/all/20090316085741.GA29986@jm.kir.nu/

but I don't really know.

johannes

[PATCH v2] wifi: mac80211: update outdated comment

[Kexin Sun]

The function ieee80211_start_scan() was refactored and replaced by
__ieee80211_start_scan() in commit f3b85252f081 ("mac80211: fix scan
races and rework scanning"). Update the comment in
ieee80211_tx_h_check_assoc() accordingly.

Additionally, remove the broken gmane.org link in the comment.

Suggested-by: Lachlan Hodges <lachlan.hodges@morsemicro.com>
Suggested-by: Johannes Berg <johannes@sipsolutions.net>
Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
v2:
 - Removed the dead gmane.org link from the comment as suggested by
   Lachlan Hodges <lachlan.hodges@morsemicro.com> 
   and Johannes Berg <johannes@sipsolutions.net>.
   
 net/mac80211/tx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 8cdbd417d7be..6dbe17f7aa74 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -287,10 +287,7 @@ ieee80211_tx_h_check_assoc(struct ieee80211_tx_data *tx)
 		 * active scan) are allowed, all other frames should not be
 		 * sent and we should not get here, but if we do
 		 * nonetheless, drop them to avoid sending them
-		 * off-channel. See the link below and
-		 * ieee80211_start_scan() for more.
-		 *
-		 * http://article.gmane.org/gmane.linux.kernel.wireless.general/30089
+		 * off-channel. See __ieee80211_start_scan() for more.
 		 */
 		return TX_DROP;
 
-- 
2.25.1