* [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64 boards
@ 2024-04-23 0:43 Dragan Simic
2024-04-23 0:43 ` [PATCH 2/2] arm64: dts: rockchip: Correct the model names " Dragan Simic
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Dragan Simic @ 2024-04-23 0:43 UTC (permalink / raw)
To: linux-rockchip
Cc: heiko, linux-arm-kernel, devicetree, robh+dt, krzk+dt, conor+dt,
linux-kernel, didi.debian, Marek Kraus
Correct the descriptions of a few Pine64 boards and devices, according
to their official names used on the Pine64 wiki. This ensures consistency
between the officially used names and the names in the source code.
Cc: Marek Kraus <gamiee@pine64.org>
Signed-off-by: Dragan Simic <dsimic@manjaro.org>
---
Notes:
This continues the description cleanup started with Radxa boards. [1]
[1] https://lore.kernel.org/linux-rockchip/1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org/
Documentation/devicetree/bindings/arm/rockchip.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index fcf7316ecd74..120db82ec4c2 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -631,20 +631,20 @@ properties:
- const: phytec,rk3288-phycore-som
- const: rockchip,rk3288
- - description: Pine64 PinebookPro
+ - description: Pine64 Pinebook Pro
items:
- const: pine64,pinebook-pro
- const: rockchip,rk3399
- description: Pine64 PineNote
items:
- enum:
- pine64,pinenote-v1.1
- pine64,pinenote-v1.2
- const: pine64,pinenote
- const: rockchip,rk3566
- - description: Pine64 PinePhonePro
+ - description: Pine64 PinePhone Pro
items:
- const: pine64,pinephone-pro
- const: rockchip,rk3399
@@ -682,7 +682,7 @@ properties:
- const: pine64,quartzpro64
- const: rockchip,rk3588
- - description: Pine64 SoQuartz SoM
+ - description: Pine64 SOQuartz
items:
- enum:
- pine64,soquartz-blade
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: rockchip: Correct the model names for Pine64 boards
2024-04-23 0:43 [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64 boards Dragan Simic
@ 2024-04-23 0:43 ` Dragan Simic
2024-04-23 15:09 ` [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions " Rob Herring
2024-04-23 15:15 ` Heiko Stuebner
2 siblings, 0 replies; 6+ messages in thread
From: Dragan Simic @ 2024-04-23 0:43 UTC (permalink / raw)
To: linux-rockchip
Cc: heiko, linux-arm-kernel, devicetree, robh+dt, krzk+dt, conor+dt,
linux-kernel, didi.debian, Marek Kraus
Correct the model names of a few Pine64 boards and devices, according
to their official names used on the Pine64 wiki. This ensures consistency
between the officially used names and the names in the source code.
Cc: Marek Kraus <gamiee@pine64.org>
Signed-off-by: Dragan Simic <dsimic@manjaro.org>
---
Notes:
This continues the model naming cleanup started with Radxa boards. [1]
These improvements may cause certain issues if some scripts misuse
/proc/device-tree/model to detect the board they're executed on. Though,
the right way to detect a board is to use /proc/device-tree/compatible
instead, because its contents is part of the ABI. Such scripts, if they
actually exist in the field, should be improved to use the right way to
detect the board model.
[1] https://lore.kernel.org/linux-rockchip/6931289a252dc2d6c7bfd2388835c5e98ba0d8c9.1713457260.git.dsimic@manjaro.org/
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 2 +-
arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
arch/arm64/boot/dts/rockchip/rk3566-soquartz-blade.dts | 2 +-
arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 2 +-
arch/arm64/boot/dts/rockchip/rk3566-soquartz-model-a.dts | 2 +-
arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi | 2 +-
arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 61f3fec5a8b1..e5709c7ee06a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -16,7 +16,7 @@
#include "rk3399-opp.dtsi"
/ {
- model = "Pine64 PinePhonePro";
+ model = "Pine64 PinePhone Pro";
compatible = "pine64,pinephone-pro", "rockchip,rk3399";
chassis-type = "handset";
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
index 59843a7a199c..0b191d8462ad 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
@@ -8,7 +8,7 @@
#include "rk3566.dtsi"
/ {
- model = "Pine64 RK3566 Quartz64-A Board";
+ model = "Pine64 Quartz64 Model A";
compatible = "pine64,quartz64-a", "rockchip,rk3566";
aliases {
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
index 2d92713be2a0..26322a358d91 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
@@ -8,7 +8,7 @@
#include "rk3566.dtsi"
/ {
- model = "Pine64 RK3566 Quartz64-B Board";
+ model = "Pine64 Quartz64 Model B";
compatible = "pine64,quartz64-b", "rockchip,rk3566";
aliases {
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-blade.dts b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-blade.dts
index fdbf1c783242..fdbb4a6a19d8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-blade.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-blade.dts
@@ -10,7 +10,7 @@
#include "rk3566-soquartz.dtsi"
/ {
- model = "PINE64 RK3566 SOQuartz on Blade carrier board";
+ model = "Pine64 SOQuartz on Blade carrier board";
compatible = "pine64,soquartz-blade", "pine64,soquartz", "rockchip,rk3566";
aliases {
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
index 6ed3fa4aee34..2b6f0df477b6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
@@ -5,7 +5,7 @@
#include "rk3566-soquartz.dtsi"
/ {
- model = "Pine64 RK3566 SoQuartz with CM4-IO Carrier Board";
+ model = "Pine64 SOQuartz on CM4-IO carrier board";
compatible = "pine64,soquartz-cm4io", "pine64,soquartz", "rockchip,rk3566";
aliases {
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-model-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-model-a.dts
index f2095dfa4eaf..9a6a63277c3d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-model-a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-model-a.dts
@@ -5,7 +5,7 @@
#include "rk3566-soquartz.dtsi"
/ {
- model = "PINE64 RK3566 SOQuartz on Model A carrier board";
+ model = "Pine64 SOQuartz on Model A carrier board";
compatible = "pine64,soquartz-model-a", "pine64,soquartz", "rockchip,rk3566";
aliases {
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
index bfb7b952f4c5..dd4e9c1893c6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi
@@ -8,7 +8,7 @@
#include "rk3566.dtsi"
/ {
- model = "Pine64 RK3566 SoQuartz SOM";
+ model = "Pine64 SOQuartz system on module";
compatible = "pine64,soquartz", "rockchip,rk3566";
aliases {
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts b/arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts
index 67414d72e2b6..e1deb9c13ad0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts
@@ -13,7 +13,7 @@
#include "rk3588.dtsi"
/ {
- model = "PINE64 QuartzPro64";
+ model = "Pine64 QuartzPro64";
compatible = "pine64,quartzpro64", "rockchip,rk3588";
aliases {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64 boards
2024-04-23 0:43 [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64 boards Dragan Simic
2024-04-23 0:43 ` [PATCH 2/2] arm64: dts: rockchip: Correct the model names " Dragan Simic
@ 2024-04-23 15:09 ` Rob Herring
2024-04-24 6:37 ` Dragan Simic
2024-04-23 15:15 ` Heiko Stuebner
2 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2024-04-23 15:09 UTC (permalink / raw)
To: Dragan Simic
Cc: Marek Kraus, linux-arm-kernel, linux-kernel, conor+dt,
devicetree, didi.debian, robh+dt, linux-rockchip, krzk+dt, heiko
On Tue, 23 Apr 2024 02:43:43 +0200, Dragan Simic wrote:
> Correct the descriptions of a few Pine64 boards and devices, according
> to their official names used on the Pine64 wiki. This ensures consistency
> between the officially used names and the names in the source code.
>
> Cc: Marek Kraus <gamiee@pine64.org>
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
> ---
>
> Notes:
> This continues the description cleanup started with Radxa boards. [1]
>
> [1] https://lore.kernel.org/linux-rockchip/1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org/
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64 boards
2024-04-23 0:43 [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64 boards Dragan Simic
2024-04-23 0:43 ` [PATCH 2/2] arm64: dts: rockchip: Correct the model names " Dragan Simic
2024-04-23 15:09 ` [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions " Rob Herring
@ 2024-04-23 15:15 ` Heiko Stuebner
2024-04-24 6:46 ` Dragan Simic
2 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2024-04-23 15:15 UTC (permalink / raw)
To: linux-rockchip, Dragan Simic
Cc: Heiko Stuebner, krzk+dt, linux-arm-kernel, Marek Kraus,
didi.debian, robh+dt, linux-kernel, devicetree, conor+dt
On Tue, 23 Apr 2024 02:43:43 +0200, Dragan Simic wrote:
> Correct the descriptions of a few Pine64 boards and devices, according
> to their official names used on the Pine64 wiki. This ensures consistency
> between the officially used names and the names in the source code.
>
>
Applied, thanks!
[1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64 boards
commit: 433dafc7b4f9f9a1011d72b32e138b598faa4807
[2/2] arm64: dts: rockchip: Correct the model names for Pine64 boards
commit: adbc5e6b457e773f1afa11fdb9b667cd492a7f82
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64 boards
2024-04-23 15:09 ` [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions " Rob Herring
@ 2024-04-24 6:37 ` Dragan Simic
0 siblings, 0 replies; 6+ messages in thread
From: Dragan Simic @ 2024-04-24 6:37 UTC (permalink / raw)
To: Rob Herring
Cc: Marek Kraus, linux-arm-kernel, linux-kernel, conor+dt,
devicetree, didi.debian, robh+dt, linux-rockchip, krzk+dt, heiko
On 2024-04-23 17:09, Rob Herring wrote:
> On Tue, 23 Apr 2024 02:43:43 +0200, Dragan Simic wrote:
>> Correct the descriptions of a few Pine64 boards and devices, according
>> to their official names used on the Pine64 wiki. This ensures
>> consistency
>> between the officially used names and the names in the source code.
>>
>> Cc: Marek Kraus <gamiee@pine64.org>
>> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
>> ---
>>
>> Notes:
>> This continues the description cleanup started with Radxa boards.
>> [1]
>>
>> [1]
>> https://lore.kernel.org/linux-rockchip/1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org/
>>
>> Documentation/devicetree/bindings/arm/rockchip.yaml | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64 boards
2024-04-23 15:15 ` Heiko Stuebner
@ 2024-04-24 6:46 ` Dragan Simic
0 siblings, 0 replies; 6+ messages in thread
From: Dragan Simic @ 2024-04-24 6:46 UTC (permalink / raw)
To: Heiko Stuebner
Cc: linux-rockchip, krzk+dt, linux-arm-kernel, Marek Kraus,
didi.debian, robh+dt, linux-kernel, devicetree, conor+dt
On 2024-04-23 17:15, Heiko Stuebner wrote:
> On Tue, 23 Apr 2024 02:43:43 +0200, Dragan Simic wrote:
>> Correct the descriptions of a few Pine64 boards and devices, according
>> to their official names used on the Pine64 wiki. This ensures
>> consistency
>> between the officially used names and the names in the source code.
>
> Applied, thanks!
>
> [1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64
> boards
> commit: 433dafc7b4f9f9a1011d72b32e138b598faa4807
> [2/2] arm64: dts: rockchip: Correct the model names for Pine64 boards
> commit: adbc5e6b457e773f1afa11fdb9b667cd492a7f82
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-24 6:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-23 0:43 [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions for Pine64 boards Dragan Simic
2024-04-23 0:43 ` [PATCH 2/2] arm64: dts: rockchip: Correct the model names " Dragan Simic
2024-04-23 15:09 ` [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions " Rob Herring
2024-04-24 6:37 ` Dragan Simic
2024-04-23 15:15 ` Heiko Stuebner
2024-04-24 6:46 ` Dragan Simic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®