From: Guenter Roeck <linux@roeck-us.net>
To: Charlie Jenkins <charlie@rivosinc.com>,
David Laight <David.Laight@aculab.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Morton <akpm@linux-foundation.org>,
Helge Deller <deller@gmx.de>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Parisc List <linux-parisc@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/2] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests
Date: Wed, 14 Feb 2024 17:24:13 -0800 [thread overview]
Message-ID: <285cd809-d5e0-4688-ace1-630aa8c30aae@roeck-us.net> (raw)
In-Reply-To: <20240214-fix_sparse_errors_checksum_tests-v8-2-36b60e673593@rivosinc.com>
On 2/14/24 13:41, Charlie Jenkins wrote:
> The test cases for ip_fast_csum and csum_ipv6_magic were failing on a
> variety of architectures that are big endian or do not support
> misalgined accesses. Both of these test cases are changed to support big
> and little endian architectures.
>
> The test for ip_fast_csum is changed to align the data along (14 +
> NET_IP_ALIGN) bytes which is the alignment of an IP header. The test for
> csum_ipv6_magic aligns the data using a struct. An extra padding field
> is added to the struct to ensure that the size of the struct is the same
> on all architectures (44 bytes).
>
> The test for csum_ipv6_magic somewhat arbitrarily aligned saddr and
> daddr. This would fail on parisc64 due to the following code snippet in
> arch/parisc/include/asm/checksum.h:
>
> add %4, %0, %0\n"
> ldd,ma 8(%1), %6\n"
> ldd,ma 8(%2), %7\n"
> add,dc %5, %0, %0\n"
>
> The second add is expecting carry flags from the first add. Normally,
> a double word load (ldd) does not modify the carry flags. However,
> because saddr and daddr may be misaligned, ldd triggers a misalignment
> trap that gets handled in arch/parisc/kernel/unaligned.c. This causes
> many additional instructions to be executed between the two adds. This
> can be easily solved by adding the carry into %0 before executing the
> ldd.
>
> However, that is not necessary since ipv6 headers should always be
> aligned on a 16-byte boundary on parisc since NET_IP_ALIGN is set to 2
> and the ethernet header size is 14.
>
> Architectures that set NET_IP_ALIGN to 0 must support misaligned saddr
> and daddr, but that is not tested here.
>
> Fixes: 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and ip_fast_csum")
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Reviewed-and-Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
prev parent reply other threads:[~2024-02-15 1:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 21:41 [PATCH v8 0/2] lib: checksum: Fix issues with checksum tests Charlie Jenkins
2024-02-14 21:41 ` [PATCH v8 1/2] lib: checksum: Fix type casting in checksum kunits Charlie Jenkins
2024-02-14 21:41 ` [PATCH v8 2/2] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests Charlie Jenkins
2024-02-14 23:03 ` Guenter Roeck
2024-02-15 1:30 ` Charlie Jenkins
2024-02-15 1:58 ` Guenter Roeck
2024-02-15 3:00 ` John David Anglin
2024-02-15 3:35 ` Charlie Jenkins
2024-02-15 4:11 ` Charlie Jenkins
2024-02-15 8:56 ` Guenter Roeck
2024-02-15 15:36 ` Charlie Jenkins
2024-02-15 16:30 ` Guenter Roeck
2024-02-15 16:51 ` Charlie Jenkins
2024-02-15 17:13 ` John David Anglin
2024-02-15 17:29 ` Guenter Roeck
2024-02-15 15:22 ` Guenter Roeck
2024-02-16 5:54 ` Helge Deller
2024-02-16 5:25 ` Guenter Roeck
2024-02-16 7:31 ` Helge Deller
2024-02-16 6:58 ` Guenter Roeck
2024-02-16 6:09 ` Guenter Roeck
2024-02-16 6:13 ` Charlie Jenkins
2024-02-16 12:05 ` Helge Deller
2024-02-16 18:22 ` John David Anglin
2024-02-15 10:27 ` David Laight
2024-02-15 15:44 ` Guenter Roeck
2024-02-15 16:51 ` John David Anglin
2024-02-15 17:06 ` Guenter Roeck
2024-02-15 17:25 ` John David Anglin
2024-02-15 18:17 ` Guenter Roeck
2024-02-15 18:56 ` John David Anglin
2024-02-15 21:00 ` Guenter Roeck
2024-02-15 21:08 ` John David Anglin
2024-02-15 18:42 ` Guenter Roeck
2024-02-15 19:41 ` David Laight
2024-02-15 19:42 ` Charlie Jenkins
2024-02-16 5:00 ` Guenter Roeck
2024-02-15 1:24 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=285cd809-d5e0-4688-ace1-630aa8c30aae@roeck-us.net \
--to=linux@roeck-us.net \
--cc=David.Laight@aculab.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=charlie@rivosinc.com \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®