From: David Howells <dhowells@redhat.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: dhowells@redhat.com, viro@ZenIV.linux.org.uk,
willy@infradead.org, andres@anarazel.de, cmaiolino@redhat.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] vfs: track per-sb writeback errors and report them via fsinfo()
Date: Tue, 10 Jul 2018 15:23:29 +0100 [thread overview]
Message-ID: <2877.1531232609@warthog.procyon.org.uk> (raw)
In-Reply-To: <20180710140127.20739-1-jlayton@kernel.org>
Jeff Layton <jlayton@kernel.org> wrote:
> v2: drop buffer.c patch to record wb errors when underlying blockdev
> flush fails. We may eventually want that, but at this point I don't have
> a clear way to test it to determine its efficacy.
>
> At LSF/MM this year, the PostgreSQL developers mentioned that they'd
> like to have some mechanism to check whether there have been any
> writeback errors on a filesystem, without necessarily flushing any of
> the cached data first.
>
> Given that we have a new fsinfo syscall being introduced, we may as well
> use it to report writeback errors on a per superblock basis. This allows
> us to provide the info that the PostgreSQL developers wanted, without
> needing to change an existing interface.
>
> This seems to do the right thing when tested by hand, but I don't yet
> have an xfstest for it, since the syscall is still quite new. Once that
> goes in and we get fsinfo support in xfs_io, it should be rather
> trivial to roll a testcase for this.
Reviewed-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2018-07-10 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 14:01 Jeff Layton
2018-07-10 14:01 ` [PATCH v2 1/4] vfs: track per-sb writeback errors Jeff Layton
2018-07-10 14:01 ` [PATCH v2 2/4] errseq: add a new errseq_scrape function Jeff Layton
2018-07-10 14:01 ` [PATCH v2 3/4] vfs: allow fsinfo to fetch the current state of s_wb_err Jeff Layton
2018-07-10 14:01 ` [PATCH v2 4/4] samples: extend test-fsinfo to access error_state Jeff Layton
2018-07-10 14:23 ` David Howells [this message]
2018-07-13 6:43 ` [PATCH v2 0/4] vfs: track per-sb writeback errors and report them via fsinfo() Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2877.1531232609@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=andres@anarazel.de \
--cc=cmaiolino@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome