RE: Hooks for random device entropy generation missing incpqarray.c

RE: Hooks for random device entropy generation missing incpqarray.c

[Cameron, Steve]

> excuse me I am using 2.4.18
> 

Ok.  If SA_SAMPLE_RANDOM is not in
the call to request_irq, you can put 
it in.  A trivial (but untested) patch: 
(if outlook doesn't mangle it) 

-- steve

--- cpqarray.c.orig	Wed Mar 20 15:25:51 2002
+++ cpqarray.c	Wed Mar 20 15:26:30 2002
@@ -516,8 +516,9 @@
 
 	
 	hba[i]->access.set_intr_mask(hba[i], 0);
-	if (request_irq(hba[i]->intr, do_ida_intr,
-		SA_INTERRUPT|SA_SHIRQ, hba[i]->devname, hba[i])) 
+	if (request_irq(hba[i]->intr, do_ida_intr, 
+		SA_SAMPLE_RANDOM|SA_INTERRUPT|SA_SHIRQ, 
+		hba[i]->devname, hba[i])) 
 	{
 
 		printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n", 

 

RE: Hooks for random device entropy generation missing incpqarray.c

[Manon Goo]

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

I have not tried your patch.  but this is in cpqarray_init() and it is only 
called when the driver is initilaized.
How is the entropy-pool further updated ?

Thanks

Manon



--On Mittwoch, 20. März 2002 15:37 Uhr -0600 "Cameron, Steve" 
<Steve.Cameron@COMPAQ.com> wrote:

>
>> excuse me I am using 2.4.18
>>
>
> Ok.  If SA_SAMPLE_RANDOM is not in
> the call to request_irq, you can put
> it in.  A trivial (but untested) patch:
> (if outlook doesn't mangle it)
>
> -- steve
>
> --- cpqarray.c.orig	Wed Mar 20 15:25:51 2002
> +++ cpqarray.c	Wed Mar 20 15:26:30 2002
> @@ -516,8 +516,9 @@
>
>
>  	hba[i]->access.set_intr_mask(hba[i], 0);
> -	if (request_irq(hba[i]->intr, do_ida_intr,
> -		SA_INTERRUPT|SA_SHIRQ, hba[i]->devname, hba[i]))
> +	if (request_irq(hba[i]->intr, do_ida_intr,
> +		SA_SAMPLE_RANDOM|SA_INTERRUPT|SA_SHIRQ,
> +		hba[i]->devname, hba[i]))
>  	{
>
>  		printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n",
>
>


[-- Attachment #2: Type: application/pgp-signature, Size: 229 bytes --]

RE: Hooks for random device entropy generation missing incpqarray.c

[Cameron, Steve]

 
> I have not tried your patch.  but this is in cpqarray_init() 
> and it is only 
> called when the driver is initilaized.
> How is the entropy-pool further updated ?

It's done in linux/arch/*/kernel/irq.c.
for i386, in handle_IRQ_event() function.

-- steve

RE: Hooks for random device entropy generation missing incpqarray.c

[Manon Goo]

OK I'll try tell you tomorrwo how iz worked out

--On Mittwoch, 20. März 2002 15:59 Uhr -0600 "Cameron, Steve" 
<Steve.Cameron@COMPAQ.com> wrote:

>
>> I have not tried your patch.  but this is in cpqarray_init()
>> and it is only
>> called when the driver is initilaized.
>> How is the entropy-pool further updated ?
>
> It's done in linux/arch/*/kernel/irq.c.
> for i386, in handle_IRQ_event() function.
>
> -- steve
>