* [PATCH] regulator: da9055: remove null pointer check on array pdata->regulators
@ 2016-09-08 9:46 Colin King
2016-09-12 16:09 ` Steve Twiss
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2016-09-08 9:46 UTC (permalink / raw)
To: Support Opensource, Liam Girdwood, Mark Brown; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
pdata->regulators is an array of DA9052_MAX_REGULATORS struct
regulator_init_data pointers hence cannot be null, so the null pointer
check on pdata->regulators is redundant. Remove it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/regulator/da9055-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-regulator.c
index d029c94..a118f63 100644
--- a/drivers/regulator/da9055-regulator.c
+++ b/drivers/regulator/da9055-regulator.c
@@ -612,7 +612,7 @@ static int da9055_regulator_probe(struct platform_device *pdev)
config.driver_data = regulator;
config.regmap = da9055->regmap;
- if (pdata && pdata->regulators) {
+ if (pdata) {
config.init_data = pdata->regulators[pdev->id];
} else {
ret = da9055_regulator_dt_init(pdev, regulator, &config,
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] regulator: da9055: remove null pointer check on array pdata->regulators
2016-09-08 9:46 [PATCH] regulator: da9055: remove null pointer check on array pdata->regulators Colin King
@ 2016-09-12 16:09 ` Steve Twiss
2016-09-12 20:44 ` Colin Ian King
0 siblings, 1 reply; 3+ messages in thread
From: Steve Twiss @ 2016-09-12 16:09 UTC (permalink / raw)
To: Colin King, Support Opensource, Liam Girdwood, Mark Brown; +Cc: linux-kernel
On 08 September 2016 10:47, Colin King wrote:
> To: Support Opensource; Liam Girdwood; Mark Brown
> Cc: linux-kernel@vger.kernel.org
> Subject: [PATCH] regulator: da9055: remove null pointer check on array pdata->regulators
>
> From: Colin Ian King <colin.king@canonical.com>
>
> pdata->regulators is an array of DA9052_MAX_REGULATORS struct
> regulator_init_data pointers hence cannot be null, so the null pointer
> check on pdata->regulators is redundant. Remove it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/regulator/da9055-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-
> regulator.c
> index d029c94..a118f63 100644
> --- a/drivers/regulator/da9055-regulator.c
> +++ b/drivers/regulator/da9055-regulator.c
> @@ -612,7 +612,7 @@ static int da9055_regulator_probe(struct
> platform_device *pdev)
> config.driver_data = regulator;
> config.regmap = da9055->regmap;
>
> - if (pdata && pdata->regulators) {
> + if (pdata) {
> config.init_data = pdata->regulators[pdev->id];
> } else {
> ret = da9055_regulator_dt_init(pdev, regulator, &config,
> --
> 2.9.3
Yes, it's true.
One my colleagues just pointed out why they had déjà vu.
May I refer to the answer that was given back in March,
https://patchwork.kernel.org/patch/8679771/
Regards,
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: da9055: remove null pointer check on array pdata->regulators
2016-09-12 16:09 ` Steve Twiss
@ 2016-09-12 20:44 ` Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2016-09-12 20:44 UTC (permalink / raw)
To: Steve Twiss, Support Opensource, Liam Girdwood, Mark Brown; +Cc: linux-kernel
On 12/09/16 17:09, Steve Twiss wrote:
>
>
>
> On 08 September 2016 10:47, Colin King wrote:
>
>> To: Support Opensource; Liam Girdwood; Mark Brown
>> Cc: linux-kernel@vger.kernel.org
>> Subject: [PATCH] regulator: da9055: remove null pointer check on array pdata->regulators
>>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> pdata->regulators is an array of DA9052_MAX_REGULATORS struct
>> regulator_init_data pointers hence cannot be null, so the null pointer
>> check on pdata->regulators is redundant. Remove it.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/regulator/da9055-regulator.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-
>> regulator.c
>> index d029c94..a118f63 100644
>> --- a/drivers/regulator/da9055-regulator.c
>> +++ b/drivers/regulator/da9055-regulator.c
>> @@ -612,7 +612,7 @@ static int da9055_regulator_probe(struct
>> platform_device *pdev)
>> config.driver_data = regulator;
>> config.regmap = da9055->regmap;
>>
>> - if (pdata && pdata->regulators) {
>> + if (pdata) {
>> config.init_data = pdata->regulators[pdev->id];
>> } else {
>> ret = da9055_regulator_dt_init(pdev, regulator, &config,
>> --
>> 2.9.3
>
> Yes, it's true.
>
> One my colleagues just pointed out why they had déjà vu.
>
> May I refer to the answer that was given back in March,
> https://patchwork.kernel.org/patch/8679771/
>
> Regards,
> Steve
>
>
Apologies for the noise. I lost track of my original patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-12 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-08 9:46 [PATCH] regulator: da9055: remove null pointer check on array pdata->regulators Colin King
2016-09-12 16:09 ` Steve Twiss
2016-09-12 20:44 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®