From: Taniya Das <quic_tdas@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
<quic_imrashai@quicinc.com>, <quic_jkona@quicinc.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Ajit Pandey <quic_ajipan@quicinc.com>
Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: sa8775p: Add support for clock controllers
Date: Tue, 3 Dec 2024 22:41:32 +0530 [thread overview]
Message-ID: <289e7959-8eae-4598-899c-16c67e66d4e9@quicinc.com> (raw)
In-Reply-To: <gpikswuggsfnfu5ay3se46ah6rdehaeu5ylaa5aidmqtcejoo2@um7inmnjrcvq>
On 12/3/2024 9:02 PM, Bjorn Andersson wrote:
> On Tue, Dec 03, 2024 at 10:04:13AM +0530, Taniya Das wrote:
>>
>>
>> On 10/26/2024 12:12 AM, Konrad Dybcio wrote:
>>> On 25.10.2024 8:42 PM, Konrad Dybcio wrote:
>>>> On 25.10.2024 10:52 AM, Taniya Das wrote:
>>>>> Add support for video, camera, display0 and display1 clock controllers
>>>>> on SA8775P. The dispcc1 will be enabled based on board requirements.
>>>
>>> Actually, why would that be? CCF should park it gracefully with
>>> unused cleanup
>>>
>>
>> Yes, CCF should take care to cleanup. But I am of an opinion that as we are
>> aware that this platform do not require the dispcc1 so we could avoid the
>> clock driver initialization and help in boot KPI.
>>
>
> Does that imply that we're guaranteed that the bootloader will never
> configure any clocks in dispcc1 that needs to be gracefully parked from
> the OS? Is this guaranteed to be the case for all QCS9100 boards?
>
Yes, bootloader will never use DISPCC1.
> IMHO we should default to correctness, and then make product-specific
> boot time optimizations from that starting point.
>
As I was sure it will not be used on this board, so I left it disabled.
> Regards,
> Bjorn
>
>>> Konrad
>>>
>>>>>
>>>>> Reviewed-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>>>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>>>>> ---
>>>>
>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>>>
>>>> Konrad
>>
>> --
>> Thanks & Regards,
>> Taniya Das.
--
Thanks & Regards,
Taniya Das.
next prev parent reply other threads:[~2024-12-03 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 8:52 [PATCH v6 0/2] Add support for videocc, camcc, dispcc0 and dispcc1 on Qualcomm SA8775P platform Taniya Das
2024-10-25 8:52 ` [PATCH v6 1/2] arm64: dts: qcom: sa8775p: Update sleep_clk frequency Taniya Das
2024-10-25 8:52 ` [PATCH v6 2/2] arm64: dts: qcom: sa8775p: Add support for clock controllers Taniya Das
2024-10-25 18:42 ` Konrad Dybcio
2024-10-25 18:42 ` Konrad Dybcio
2024-12-03 4:34 ` Taniya Das
2024-12-03 15:32 ` Bjorn Andersson
2024-12-03 17:11 ` Taniya Das [this message]
2024-12-26 18:27 ` [PATCH v6 0/2] Add support for videocc, camcc, dispcc0 and dispcc1 on Qualcomm SA8775P platform Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=289e7959-8eae-4598-899c-16c67e66d4e9@quicinc.com \
--to=quic_tdas@quicinc.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®