mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Huang, Kai" <kai.huang@intel.com>
To: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"nik.borisov@suse.com" <nik.borisov@suse.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Raj, Ashok" <ashok.raj@intel.com>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"david@redhat.com" <david@redhat.com>,
	"bagasdotme@gmail.com" <bagasdotme@gmail.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	"kirill.shutemov@linux.intel.com"
	<kirill.shutemov@linux.intel.com>, "Christopherson,,
	Sean" <seanjc@google.com>, "mingo@redhat.com" <mingo@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"Yamahata, Isaku" <isaku.yamahata@intel.com>,
	"Chatre, Reinette" <reinette.chatre@intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"Shahar, Sagi" <sagis@google.com>,
	"imammedo@redhat.com" <imammedo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>, "Gao, Chao" <chao.gao@intel.com>,
	"Brown, Len" <len.brown@intel.com>,
	"sathyanarayanan.kuppuswamy@linux.intel.com" 
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	"Huang, Ying" <ying.huang@intel.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v13 07/22] x86/virt/tdx: Add skeleton to enable TDX on demand
Date: Fri, 8 Sep 2023 10:16:22 +0000	[thread overview]
Message-ID: <28b9c9cae8a408cece4f00d75deea5aa85a88ecf.camel@intel.com> (raw)
In-Reply-To: <4a135404-4661-fa80-a3e7-fb131cdf2e6c@suse.com>

On Thu, 2023-09-07 at 17:19 +0300, Nikolay Borisov wrote:
> > +/*
> > + * Do the module global initialization if not done yet.  It can be
> > + * done on any cpu.  It's always called with interrupts disabled.
> 
> nit: Add lockdep_assert_irqs_off rather than the comment, the same way 
> it's done for the lp enable function below.

Yeah can do.  Thanks.  I didn't do because tdx_cpu_enable() already does it.

  reply	other threads:[~2023-09-08 10:16 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25 12:14 [PATCH v13 00/22] TDX host kernel support Kai Huang
2023-08-25 12:14 ` [PATCH v13 01/22] x86/virt/tdx: Detect TDX during kernel boot Kai Huang
2023-09-08 15:19   ` Dave Hansen
2023-08-25 12:14 ` [PATCH v13 02/22] x86/tdx: Define TDX supported page sizes as macros Kai Huang
2023-08-25 12:14 ` [PATCH v13 03/22] x86/virt/tdx: Make INTEL_TDX_HOST depend on X86_X2APIC Kai Huang
2023-08-25 12:14 ` [PATCH v13 04/22] x86/cpu: Detect TDX partial write machine check erratum Kai Huang
2023-09-08 15:22   ` Dave Hansen
2023-09-11 12:39     ` Huang, Kai
2023-08-25 12:14 ` [PATCH v13 05/22] x86/virt/tdx: Handle SEAMCALL no entropy error in common code Kai Huang
2023-09-08 16:21   ` Dave Hansen
2023-09-11 11:41     ` Huang, Kai
2023-08-25 12:14 ` [PATCH v13 06/22] x86/virt/tdx: Add SEAMCALL error printing for module initialization Kai Huang
2023-09-07 12:45   ` Nikolay Borisov
2023-09-08 10:33     ` Huang, Kai
2023-09-08 10:38       ` Nikolay Borisov
2023-09-08 11:00         ` Huang, Kai
2023-09-08 16:31   ` Dave Hansen
2023-09-11 12:07     ` Huang, Kai
2023-08-25 12:14 ` [PATCH v13 07/22] x86/virt/tdx: Add skeleton to enable TDX on demand Kai Huang
2023-09-07 14:19   ` Nikolay Borisov
2023-09-08 10:16     ` Huang, Kai [this message]
2023-08-25 12:14 ` [PATCH v13 08/22] x86/virt/tdx: Get information about TDX module and TDX-capable memory Kai Huang
2023-08-25 12:14 ` [PATCH v13 09/22] x86/virt/tdx: Use all system memory when initializing TDX module as TDX memory Kai Huang
2023-08-25 12:14 ` [PATCH v13 10/22] x86/virt/tdx: Add placeholder to construct TDMRs to cover all TDX memory regions Kai Huang
2023-08-25 12:14 ` [PATCH v13 11/22] x86/virt/tdx: Fill out " Kai Huang
2023-08-25 12:14 ` [PATCH v13 12/22] x86/virt/tdx: Allocate and set up PAMTs for TDMRs Kai Huang
2023-08-25 12:14 ` [PATCH v13 13/22] x86/virt/tdx: Designate reserved areas for all TDMRs Kai Huang
2023-08-25 12:14 ` [PATCH v13 14/22] x86/virt/tdx: Configure TDX module with the TDMRs and global KeyID Kai Huang
2023-08-25 12:14 ` [PATCH v13 15/22] x86/virt/tdx: Configure global KeyID on all packages Kai Huang
2023-08-25 12:14 ` [PATCH v13 16/22] x86/virt/tdx: Initialize all TDMRs Kai Huang
2023-08-25 12:14 ` [PATCH v13 17/22] x86/kexec: Flush cache of TDX private memory Kai Huang
2023-09-15 17:43   ` Edgecombe, Rick P
2023-09-15 17:50     ` Dave Hansen
2023-09-18 12:08       ` Huang, Kai
2023-09-18 15:44         ` Dave Hansen
2023-09-18 22:14           ` Huang, Kai
2023-08-25 12:14 ` [PATCH v13 18/22] x86/virt/tdx: Keep TDMRs when module initialization is successful Kai Huang
2023-09-15 23:10   ` Edgecombe, Rick P
2023-09-15 23:10   ` Edgecombe, Rick P
2023-08-25 12:14 ` [PATCH v13 19/22] x86/virt/tdx: Improve readibility of module initialization error handling Kai Huang
2023-09-15 23:14   ` Edgecombe, Rick P
2023-08-25 12:14 ` [PATCH v13 20/22] x86/kexec(): Reset TDX private memory on platforms with TDX erratum Kai Huang
2023-09-14 21:36   ` Edgecombe, Rick P
2023-09-15 11:42     ` Huang, Kai
2023-09-15 16:42       ` Edgecombe, Rick P
2023-09-18  4:36         ` Huang, Kai
2023-08-25 12:14 ` [PATCH v13 21/22] x86/mce: Improve error log of kernel space TDX #MC due to erratum Kai Huang
2023-08-25 12:14 ` [PATCH v13 22/22] Documentation/x86: Add documentation for TDX host support Kai Huang
2023-09-11 11:32   ` Nikolay Borisov
2023-09-13 11:27     ` Huang, Kai
2023-09-28  7:48 ` [PATCH v13 00/22] TDX host kernel support Nikolay Borisov
2023-09-28 10:19   ` Huang, Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28b9c9cae8a408cece4f00d75deea5aa85a88ecf.camel@intel.com \
    --to=kai.huang@intel.com \
    --cc=ak@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=bagasdotme@gmail.com \
    --cc=bp@alien8.de \
    --cc=chao.gao@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=david@redhat.com \
    --cc=hpa@zytor.com \
    --cc=imammedo@redhat.com \
    --cc=isaku.yamahata@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nik.borisov@suse.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=reinette.chatre@intel.com \
    --cc=sagis@google.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome