From: Minchan Kim <minchan.kim@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-mips <linux-mips@linux-mips.org>,
Namjae Jeon <linkinjeon@gmail.com>
Subject: data consistency of high page
Date: Tue, 23 Mar 2010 17:46:52 +0900 [thread overview]
Message-ID: <28c262361003230146o7bca61e6h3af2062b1172fdb2@mail.gmail.com> (raw)
Hi, Ralf.
Below is thread long time ago.
At that time, we can't end up the problem by some reason.
Sorry for that.
The problem would occur, again.
On Fri, Oct 16, 2009 at 6:24 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Fri, Oct 16, 2009 at 02:17:19PM +0900, Minchan Kim wrote:
>
>> Many code of kernel fs usually allocate high page and flush.
>> But flush_dcache_page of mips checks PageHighMem to avoid flush
>> so that data consistency is broken, I think.
>
> What processor and cache configuration?
>
>> I found it's by you and Atsushi-san on 585fa724.
>> Why do we need the check?
>> Could you elaborte please?
>
> The if statement exists because __flush_dcache_page would crash if a page
> is not mapped. This of course isn't correct but that wasn't a problem
> since highmem still is only supported on machines that don't have aliases.
>
> Ralf
>
Our system is following as.
mips 34ke
primary i-cache 32kB VIPT 4way 32 byte line size.
primary d-cache 32kB 4way 32 bytes linesize
If you have further questions, Namjae, Could you follow question of Ralf?
--
Kind regards,
Minchan Kim
next reply other threads:[~2010-03-23 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 8:46 Minchan Kim [this message]
2010-03-23 12:11 ` NamJae Jeon
2011-04-05 8:17 ` NamJae Jeon
[not found] ` <CAF1ZMEdh19eNbknfNskQxKeo0sjP7ELOAdRi9zD5VEqTLBXj6Q@mail.gmail.com>
2012-02-28 7:09 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c262361003230146o7bca61e6h3af2062b1172fdb2@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®