mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Clark <james.clark@linaro.org>
To: Leo Yan <leo.yan@arm.com>
Cc: John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
	Leo Yan <leo.yan@linux.dev>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Al Grant <al.grant@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] perf arm_spe: Turn event name mappings into an array
Date: Thu, 2 Apr 2026 10:48:41 +0100	[thread overview]
Message-ID: <28cc665e-ac0c-4efd-89a6-3ac0d9a41752@linaro.org> (raw)
In-Reply-To: <20260402091300.GF356832@e132581.arm.com>



On 02/04/2026 10:13 am, Leo Yan wrote:
> On Wed, Apr 01, 2026 at 03:25:50PM +0100, James Clark wrote:
>> This is so we can have a single function that prints events and can be
>> used with multiple mappings from different CPUs. Remove any bit that was
>> printed so that later we can print out the remaining unknown impdef
>> bits.
>>
>> No functional changes intended.
>>
>> Signed-off-by: James Clark <james.clark@linaro.org>
>> ---
>>   .../util/arm-spe-decoder/arm-spe-pkt-decoder.c     | 88 +++++++++++-----------
>>   1 file changed, 43 insertions(+), 45 deletions(-)
>>
>> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
>> index 5769ba2f4140..c880b0dec3a1 100644
>> --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
>> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
>> @@ -276,6 +276,48 @@ static int arm_spe_pkt_out_string(int *err, char **buf_p, size_t *blen,
>>   	return ret;
>>   }
>>   
>> +struct ev_string {
>> +	u8 event;
>> +	const char *desc;
>> +};
> 
> Maybe we can have more ambition to define a more general structure:
> 
>    struct packet_field_string {
>    	u64 bit_mask;
>    	u64 bit_val;
>    	const char *desc;
>    };
> 
> Thus, this also can be used by other bit fields decoding.  We can do
> this now or if later refactor for other packets.
> 
> Either way is fine for me:
> 
> Reviewed-by: Leo Yan <leo.yan@arm.com>
> 

Thanks. I think I'll leave it as it is, there's a risk of making it too 
generic and then it doesn't fit any other use case anyway. We can always 
add it later.

>> +
>> +static const struct ev_string common_ev_strings[] = {
>> +	{ .event = EV_EXCEPTION_GEN, .desc = "EXCEPTION-GEN" },
>> +	{ .event = EV_RETIRED, .desc = "RETIRED" },
>> +	{ .event = EV_L1D_ACCESS, .desc = "L1D-ACCESS" },
>> +	{ .event = EV_L1D_REFILL, .desc = "L1D-REFILL" },
>> +	{ .event = EV_TLB_ACCESS, .desc = "TLB-ACCESS" },
>> +	{ .event = EV_TLB_WALK, .desc = "TLB-REFILL" },
>> +	{ .event = EV_NOT_TAKEN, .desc = "NOT-TAKEN" },
>> +	{ .event = EV_MISPRED, .desc = "MISPRED" },
>> +	{ .event = EV_LLC_ACCESS, .desc = "LLC-ACCESS" },
>> +	{ .event = EV_LLC_MISS, .desc = "LLC-REFILL" },
>> +	{ .event = EV_REMOTE_ACCESS, .desc = "REMOTE-ACCESS" },
>> +	{ .event = EV_ALIGNMENT, .desc = "ALIGNMENT" },
>> +	{ .event = EV_TRANSACTIONAL, .desc = "TXN" },
>> +	{ .event = EV_PARTIAL_PREDICATE, .desc = "SVE-PARTIAL-PRED" },
>> +	{ .event = EV_EMPTY_PREDICATE, .desc = "SVE-EMPTY-PRED" },
>> +	{ .event = EV_L2D_ACCESS, .desc = "L2D-ACCESS" },
>> +	{ .event = EV_L2D_MISS, .desc = "L2D-MISS" },
>> +	{ .event = EV_CACHE_DATA_MODIFIED, .desc = "HITM" },
>> +	{ .event = EV_RECENTLY_FETCHED, .desc = "LFB" },
>> +	{ .event = EV_DATA_SNOOPED, .desc = "SNOOPED" },
>> +	{ .event = EV_STREAMING_SVE_MODE, .desc = "STREAMING-SVE" },
>> +	{ .event = EV_SMCU, .desc = "SMCU" },
>> +	{ .event = 0, .desc = NULL },
>> +};
>> +
>> +static u64 print_event_list(int *err, char **buf, size_t *buf_len,
>> +			    const struct ev_string *ev_strings, u64 payload)
>> +{
>> +	for (const struct ev_string *ev = ev_strings; ev->desc != NULL; ev++) {
>> +		if (payload & BIT(ev->event))
>> +			arm_spe_pkt_out_string(err, buf, buf_len, " %s", ev->desc);
>> +		payload &= ~BIT(ev->event);
>> +	}
>> +	return payload;
>> +}
>> +
>>   static int arm_spe_pkt_desc_event(const struct arm_spe_pkt *packet,
>>   				  char *buf, size_t buf_len)
>>   {
>> @@ -283,51 +325,7 @@ static int arm_spe_pkt_desc_event(const struct arm_spe_pkt *packet,
>>   	int err = 0;
>>   
>>   	arm_spe_pkt_out_string(&err, &buf, &buf_len, "EV");
>> -
>> -	if (payload & BIT(EV_EXCEPTION_GEN))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " EXCEPTION-GEN");
>> -	if (payload & BIT(EV_RETIRED))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " RETIRED");
>> -	if (payload & BIT(EV_L1D_ACCESS))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " L1D-ACCESS");
>> -	if (payload & BIT(EV_L1D_REFILL))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " L1D-REFILL");
>> -	if (payload & BIT(EV_TLB_ACCESS))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " TLB-ACCESS");
>> -	if (payload & BIT(EV_TLB_WALK))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " TLB-REFILL");
>> -	if (payload & BIT(EV_NOT_TAKEN))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " NOT-TAKEN");
>> -	if (payload & BIT(EV_MISPRED))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " MISPRED");
>> -	if (payload & BIT(EV_LLC_ACCESS))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " LLC-ACCESS");
>> -	if (payload & BIT(EV_LLC_MISS))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " LLC-REFILL");
>> -	if (payload & BIT(EV_REMOTE_ACCESS))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " REMOTE-ACCESS");
>> -	if (payload & BIT(EV_ALIGNMENT))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " ALIGNMENT");
>> -	if (payload & BIT(EV_TRANSACTIONAL))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " TXN");
>> -	if (payload & BIT(EV_PARTIAL_PREDICATE))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " SVE-PARTIAL-PRED");
>> -	if (payload & BIT(EV_EMPTY_PREDICATE))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " SVE-EMPTY-PRED");
>> -	if (payload & BIT(EV_L2D_ACCESS))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " L2D-ACCESS");
>> -	if (payload & BIT(EV_L2D_MISS))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " L2D-MISS");
>> -	if (payload & BIT(EV_CACHE_DATA_MODIFIED))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " HITM");
>> -	if (payload & BIT(EV_RECENTLY_FETCHED))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " LFB");
>> -	if (payload & BIT(EV_DATA_SNOOPED))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " SNOOPED");
>> -	if (payload & BIT(EV_STREAMING_SVE_MODE))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " STREAMING-SVE");
>> -	if (payload & BIT(EV_SMCU))
>> -		arm_spe_pkt_out_string(&err, &buf, &buf_len, " SMCU");
>> +	print_event_list(&err, &buf, &buf_len, common_ev_strings, payload);
>>   
>>   	return err;
>>   }
>>
>> -- 
>> 2.34.1
>>
>>


  reply	other threads:[~2026-04-02  9:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 14:25 [PATCH 0/4] perf arm_spe: Dump IMPDEF events James Clark
2026-04-01 14:25 ` [PATCH 1/4] perf arm_spe: Make a function to get the MIDR James Clark
2026-04-02  8:55   ` Leo Yan
2026-04-01 14:25 ` [PATCH 2/4] perf arm_spe: Turn event name mappings into an array James Clark
2026-04-02  9:13   ` Leo Yan
2026-04-02  9:48     ` James Clark [this message]
2026-04-02 15:30   ` Ian Rogers
2026-04-01 14:25 ` [PATCH 3/4] perf arm_spe: Decode Arm N1 IMPDEF events James Clark
2026-04-02  9:32   ` Leo Yan
2026-04-02  9:49     ` James Clark
2026-04-02 15:26   ` Ian Rogers
2026-04-07 12:35     ` James Clark
2026-04-07 18:26       ` Ian Rogers
2026-04-08  8:47         ` James Clark
2026-04-10  4:51           ` Namhyung Kim
2026-04-01 14:25 ` [PATCH 4/4] perf arm_spe: Print remaining IMPDEF event numbers James Clark
2026-04-02  9:46   ` Leo Yan
2026-04-06 18:18 ` [PATCH 0/4] perf arm_spe: Dump IMPDEF events Namhyung Kim
2026-04-07  8:18   ` James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28cc665e-ac0c-4efd-89a6-3ac0d9a41752@linaro.org \
    --to=james.clark@linaro.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=al.grant@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®