From: James Clark <james.clark@linaro.org>
To: Leo Yan <leo.yan@arm.com>
Cc: John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
Leo Yan <leo.yan@linux.dev>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Al Grant <al.grant@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] perf arm_spe: Decode Arm N1 IMPDEF events
Date: Thu, 2 Apr 2026 10:49:45 +0100 [thread overview]
Message-ID: <11fd32e8-07e1-4889-bd02-5eb38b7e1ed1@linaro.org> (raw)
In-Reply-To: <20260402093234.GG356832@e132581.arm.com>
On 02/04/2026 10:32 am, Leo Yan wrote:
> On Wed, Apr 01, 2026 at 03:25:51PM +0100, James Clark wrote:
>
> [...]
>
>> static int arm_spe_pkt_desc_event(const struct arm_spe_pkt *packet,
>> - char *buf, size_t buf_len)
>> + char *buf, size_t buf_len, u64 midr)
>
> Just wandering if we can add a "midr" field into struct arm_spe_pkt ?
> Then we don't need to change many functions for populating midr.
>
> The rest is good for me.
>
> Thanks,
> Leo
Yeah I can do that. I was worried they were stored in an array and it
would be a waste of space, but they're not so it's ok.
next prev parent reply other threads:[~2026-04-02 9:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 14:25 [PATCH 0/4] perf arm_spe: Dump " James Clark
2026-04-01 14:25 ` [PATCH 1/4] perf arm_spe: Make a function to get the MIDR James Clark
2026-04-02 8:55 ` Leo Yan
2026-04-01 14:25 ` [PATCH 2/4] perf arm_spe: Turn event name mappings into an array James Clark
2026-04-02 9:13 ` Leo Yan
2026-04-02 9:48 ` James Clark
2026-04-02 15:30 ` Ian Rogers
2026-04-01 14:25 ` [PATCH 3/4] perf arm_spe: Decode Arm N1 IMPDEF events James Clark
2026-04-02 9:32 ` Leo Yan
2026-04-02 9:49 ` James Clark [this message]
2026-04-02 15:26 ` Ian Rogers
2026-04-07 12:35 ` James Clark
2026-04-07 18:26 ` Ian Rogers
2026-04-08 8:47 ` James Clark
2026-04-10 4:51 ` Namhyung Kim
2026-04-01 14:25 ` [PATCH 4/4] perf arm_spe: Print remaining IMPDEF event numbers James Clark
2026-04-02 9:46 ` Leo Yan
2026-04-06 18:18 ` [PATCH 0/4] perf arm_spe: Dump IMPDEF events Namhyung Kim
2026-04-07 8:18 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11fd32e8-07e1-4889-bd02-5eb38b7e1ed1@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®