From: Stefan Wahren <stefan.wahren@i2se.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Philippe Reynes <tremyfr@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show()
Date: Tue, 9 May 2017 09:07:52 +0200 [thread overview]
Message-ID: <290d2473-73bd-70db-b6ef-c50331812f31@i2se.com> (raw)
In-Reply-To: <9932ee63-f766-49ce-d760-9a0bd06f0657@users.sourceforge.net>
Am 08.05.2017 um 19:29 schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 8 May 2017 19:21:27 +0200
>
> A bit of data was put into a sequence by separate function calls.
> Print the same data together with adjusted seq_printf() calls instead.
Sorry, i'm not happy with this patch. It doesn't increase readabilityand
mixes the output of multiple lines.
The only benefit is a little bit higher performance. But for debugfs
this won't be necessary.
Stefan
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/net/ethernet/qualcomm/qca_debug.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
next prev parent reply other threads:[~2017-05-09 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 17:29 SF Markus Elfring
2017-05-09 7:07 ` Stefan Wahren [this message]
2017-05-09 7:57 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=290d2473-73bd-70db-b6ef-c50331812f31@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®