mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sui Jingfeng <15330273260@189.cn>, Rob Herring <robh@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Roland Scheidegger <sroland@vmware.com>,
	Zack Rusin <zackr@vmware.com>,
	Christian Gmeiner <christian.gmeiner@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	"David S . Miller" <davem@davemloft.net>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Ilia Mirkin <imirkin@alum.mit.edu>,
	Qing Zhang <zhangqing@loongson.cn>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v10 2/4] Documentation/dt: Add descriptions for loongson display controller
Date: Wed, 23 Feb 2022 16:44:02 +0100	[thread overview]
Message-ID: <2929cc96-b272-7144-f4a4-71d60852c5cd@kernel.org> (raw)
In-Reply-To: <72e3790f-088d-1a70-a5f7-3a18c14a6eae@189.cn>

On 23/02/2022 16:35, Sui Jingfeng wrote:
> 
> On 2022/2/23 21:56, 隋景峰 wrote:
>> Something like this:
>>   
>> dt-bindings: display: Add Loongson display controller
> 
> Hi,

Thanks for resending in a proper format. I already replied to your
original post, so let me paste it here as well.

> 
> We are not a platform device driver, there is no
> of_device_id defined in my driver. In other word,
> my driver will not bind against devices whose compatible
> is "loongson,ls7a1000-dc". We just parse the device tree
> actively, find necessary information of interest.
> 
> What's the meaning of dt-bindings by definition ?
> In this case, can I use the word "dt-bindings" in the commit title?

This is a patch for specific subsystem, so as Rob said, it should follow
subsystem conventions.

The patch itself is a dt-bindings patch, so there is nothing here
special which would encourage for any exception.

> 
> I want to follow the conventions, but get some push back,
> Krzysztof say that he can not see any bindings, these are not bindings.

I said in comment to your patch with DTS, which you called bindings,
that there are no bindings at all in it. Because in your patch with DTS
you did not include bindings, but you called it bindings.

Here, this is a patch with bindings, so your comment "these are not
bindings" is not true.

Best regards,
Krzysztof

  reply	other threads:[~2022-02-23 15:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-20 14:55 [PATCH v10 0/4] drm/lsdc: add drm driver " Sui Jingfeng
2022-02-20 14:55 ` [PATCH v10 1/4] MIPS: Loongson64: dts: update the display controller device node Sui Jingfeng
2022-02-20 18:18   ` Jiaxun Yang
2022-02-21  1:27     ` Sui Jingfeng
2022-02-21  9:19   ` Sergei Shtylyov
2022-02-21 10:01     ` Krzysztof Kozlowski
2022-02-21 13:57       ` Sui Jingfeng
2022-02-21 13:53     ` Sui Jingfeng
2022-02-20 14:55 ` [PATCH v10 2/4] Documentation/dt: Add descriptions for loongson display controller Sui Jingfeng
2022-02-20 18:22   ` Jiaxun Yang
2022-02-21  7:31     ` Krzysztof Kozlowski
2022-02-22 23:02   ` Rob Herring
2022-02-23 13:56     ` 隋景峰
2022-02-23 15:35       ` Sui Jingfeng
2022-02-23 15:44         ` Krzysztof Kozlowski [this message]
2022-02-23 15:40       ` Krzysztof Kozlowski
2022-02-20 14:55 ` [PATCH v10 3/4] drm/lsdc: add drm driver " Sui Jingfeng
2022-02-22  8:27   ` Maxime Ripard
2022-02-22 13:53     ` Sui Jingfeng
2022-02-22 14:46     ` Sui Jingfeng
2022-02-23 14:39       ` Maxime Ripard
2022-02-23 15:14         ` Sui Jingfeng
2022-02-23 15:41           ` Maxime Ripard
2022-02-23 15:45         ` Sui Jingfeng
2022-02-23 12:47   ` kernel test robot
2022-02-20 14:55 ` [PATCH v10 4/4] MAINTAINERS: add maintainers for DRM LSDC driver Sui Jingfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2929cc96-b272-7144-f4a4-71d60852c5cd@kernel.org \
    --to=krzk@kernel.org \
    --cc=15330273260@189.cn \
    --cc=airlied@linux.ie \
    --cc=andrey.zhizhikin@leica-geosystems.com \
    --cc=christian.gmeiner@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imirkin@alum.mit.edu \
    --cc=jiaxun.yang@flygoat.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sroland@vmware.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=tzimmermann@suse.de \
    --cc=zackr@vmware.com \
    --cc=zhangqing@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®