Re: [RFC PATCH 11/20] powerpc/io: Remove PCI_FIX_ADDR

["Arnd Bergmann" <arnd@arndb.de>]

On Thu, Nov 14, 2024, at 13:51, Michael Ellerman wrote:
> Now that PPC_INDIRECT_MMIO is removed, PCI_FIX_ADDR does nothing, so
> remove it.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Acked-by: Arnd Bergmann <arnd@arndb.de>
 
>  static inline unsigned char __raw_readb(const volatile void __iomem *addr)
>  {
> -	return *(volatile unsigned char __force *)PCI_FIX_ADDR(addr);
> +	return *(volatile unsigned char __force *)addr;
>  }
>  #define __raw_readb __raw_readb
> 
>  static inline unsigned short __raw_readw(const volatile void __iomem *addr)
>  {
> -	return *(volatile unsigned short __force *)PCI_FIX_ADDR(addr);
> +	return *(volatile unsigned short __force *)addr;
>  }

I think the __raw_ accessors are all identical to the
version in asm-generic and can be removed altogether.

> +#define __do_writeb(val, addr)	out_8(addr, val)
> +#define __do_writew(val, addr)	out_le16(addr, val)
> +#define __do_writel(val, addr)	out_le32(addr, val)
> +#define __do_writeq(val, addr)	out_le64(addr, val)
> +#define __do_writew_be(val, addr) out_be16(addr, val)
> +#define __do_writel_be(val, addr) out_be32(addr, val)
> +#define __do_writeq_be(val, addr) out_be64(addr, val)
 
These should no longer be needed either since 
arch/powerpc/include/asm/io-defs.h only needs to redirect
the inb/outb calls but not readl/writel and the string 
operations.

      Arnd