Re: [PATCH v6] sbitmap: fix io hung due to race on sbitmap_word::cleared

[Bart Van Assche <bvanassche@acm.org>]

On 7/11/24 6:01 PM, Ming Lei wrote:
> On Fri, Jul 12, 2024 at 12:33 AM Bart Van Assche <bvanassche@acm.org> wrote:
>> The comment above 'swap_lock' in this patch is as follows:
>>
>>          /**
>>           * @swap_lock: Held while swapping word <-> cleared
>>           */
>>
>> In other words, 'swap_lock' is used to serialize *code*. Using
>> synchronization objects to serialize code is known as an anti-pattern,
>> something that shouldn't be done.
> 
>> Synchronization objects should be used
>> to serialize access to data.
> 
> It can be thought of serializing UPDATE on both ->word and ->cleared,
> instead of code.

It would be appreciated if the comment above swap_lock would be modified
such that it reflects that it serializes simultaneous updates of ->word
and ->cleared.

Thanks,

Bart.