From: David Howells <dhowells@redhat.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] security: use READ_ONCE instead of deprecated ACCESS_ONCE
Date: Fri, 10 Feb 2017 11:20:44 +0000 [thread overview]
Message-ID: <29606.1486725644@warthog.procyon.org.uk> (raw)
In-Reply-To: <1479584622-7570-1-git-send-email-dave@stgolabs.net>
Davidlohr Bueso <dave@stgolabs.net> wrote:
> With the new standardized functions, we can replace all ACCESS_ONCE()
> calls across relevant security/keyrings/.
>
> ACCESS_ONCE() does not work reliably on non-scalar types. For example
> gcc 4.6 and 4.7 might remove the volatile tag for such accesses during
> the SRA (scalar replacement of aggregates) step:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
>
> Update the new calls regardless of if it is a scalar type, this is
> cleaner than having three alternatives.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Applied.
prev parent reply other threads:[~2017-02-10 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 19:43 Davidlohr Bueso
2017-02-10 11:20 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29606.1486725644@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®