From: Arnd Bergmann <arnd@arndb.de>
To: Xiubo Li <lixiubo@cmss.chinamobile.com>
Cc: broonie@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] regmap: add 64-bit mode support
Date: Wed, 09 Dec 2015 09:45:59 +0100 [thread overview]
Message-ID: <2974042.RS5oNhyniO@wuerfel> (raw)
In-Reply-To: <1449135113-31892-3-git-send-email-lixiubo@cmss.chinamobile.com>
On Thursday 03 December 2015 17:31:52 Xiubo Li wrote:
> @@ -2488,11 +2581,17 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val,
> * we assume that the values are native
> * endian.
> */
> + u64 *u64 = val;
> u32 *u32 = val;
> u16 *u16 = val;
> u8 *u8 = val;
>
> switch (map->format.val_bytes) {
> +#ifdef CONFIG_64BIT
> + case 8:
> + u64[i] = ival;
> + break;
> +#endif
> case 4:
> u32[i] = ival;
> break;
>
This now gives me:
drivers/base/regmap/regmap.c: In function 'regmap_bulk_read':
drivers/base/regmap/regmap.c:2584:10: warning: unused variable 'u64' [-Wunused-variable]
u64 *u64 = val;
^
Arnd
next prev parent reply other threads:[~2015-12-09 8:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 9:31 [PATCH 0/3] regmap: add 64-bit support Xiubo Li
2015-12-03 9:31 ` [PATCH 1/3] regmap: cache: Tidy up the code to suppress style check warnings Xiubo Li
2015-12-08 17:12 ` Mark Brown
2015-12-09 3:30 ` [PATCH 1/3] regmap: cache: Tidy up the code to suppress stylecheck warnings Xiubo Li
2015-12-03 9:31 ` [PATCH 2/3] regmap: add 64-bit mode support Xiubo Li
2015-12-08 19:11 ` Applied "regmap: add 64-bit mode support" to the regmap tree Mark Brown
2015-12-09 8:45 ` Arnd Bergmann [this message]
2015-12-09 9:01 ` [PATCH 2/3] regmap: add 64-bit mode support Xiubo Li
2015-12-03 9:31 ` [PATCH 3/3] regcache: " Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2974042.RS5oNhyniO@wuerfel \
--to=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®