mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiubo Li <lixiubo@cmss.chinamobile.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] regmap: cache: Tidy up the code to suppress stylecheck warnings
Date: Wed, 09 Dec 2015 11:30:59 +0800	[thread overview]
Message-ID: <5667A073.60309@cmss.chinamobile.com> (raw)
In-Reply-To: <20151208171235.GV5727@sirena.org.uk>


On 09/12/2015 01:12, Mark Brown wrote:
> On Thu, Dec 03, 2015 at 05:31:51PM +0800, Xiubo Li wrote:
>
>> There will be some warning like the following when checking new
>> patches near this code:
>>      "WARNING: Missing a blank line after declarations"
>> This patch will suppress this warning.
>>   	switch (map->cache_word_size) {
>> -	case 1: {
>> -		u8 *cache = base;
>> -		cache[idx] = val;
>> +	case 1:
>> +		((u8 *)base)[idx] = val;
>>   		break;
>> -	}
> If there's a change to shut checkpatch up I'd rather just add the blank
> line it's asking for - the code is the way it is currently to avoid the
> casts since they're hard for people to read.
Both of them are okay for me.

I will send the v2 for these just adding one blank line.

Thanks,

BRs

Xiubo






  reply	other threads:[~2015-12-09  3:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03  9:31 [PATCH 0/3] regmap: add 64-bit support Xiubo Li
2015-12-03  9:31 ` [PATCH 1/3] regmap: cache: Tidy up the code to suppress style check warnings Xiubo Li
2015-12-08 17:12   ` Mark Brown
2015-12-09  3:30     ` Xiubo Li [this message]
2015-12-03  9:31 ` [PATCH 2/3] regmap: add 64-bit mode support Xiubo Li
2015-12-08 19:11   ` Applied "regmap: add 64-bit mode support" to the regmap tree Mark Brown
2015-12-09  8:45   ` [PATCH 2/3] regmap: add 64-bit mode support Arnd Bergmann
2015-12-09  9:01     ` Xiubo Li
2015-12-03  9:31 ` [PATCH 3/3] regcache: " Xiubo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5667A073.60309@cmss.chinamobile.com \
    --to=lixiubo@cmss.chinamobile.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®