* [PATCH] phy: Fix error handling in tegra_xusb_pad_init
@ 2025-11-03 10:30 Ma Ke
2025-11-03 11:29 ` Jon Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Ma Ke @ 2025-11-03 10:30 UTC (permalink / raw)
To: jckuo, vkoul, kishon, thierry.reding, jonathanh, mchehab,
wentong.wu, sakari.ailus
Cc: linux-phy, linux-tegra, linux-kernel, akpm, Ma Ke, stable
If device_add() fails, do not use device_unregister() for error
handling. device_unregister() consists two functions: device_del() and
put_device(). device_unregister() should only be called after
device_add() succeeded because device_del() undoes what device_add()
does if successful. Change device_unregister() to put_device() call
before returning from the function.
As comment of device_add() says, 'if device_add() succeeds, you should
call device_del() when you want to get rid of it. If device_add() has
not succeeded, use only put_device() to drop the reference count'.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: 78876f71b3e9 ("media: pci: intel: ivsc: Add ACE submodule")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/phy/tegra/xusb.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index c89df95aa6ca..d89493d68699 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -171,16 +171,16 @@ int tegra_xusb_pad_init(struct tegra_xusb_pad *pad,
err = dev_set_name(&pad->dev, "%s", pad->soc->name);
if (err < 0)
- goto unregister;
+ goto put_device;
err = device_add(&pad->dev);
if (err < 0)
- goto unregister;
+ goto put_device;
return 0;
-unregister:
- device_unregister(&pad->dev);
+put_device:
+ put_device(&pad->dev);
return err;
}
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: Fix error handling in tegra_xusb_pad_init
2025-11-03 10:30 [PATCH] phy: Fix error handling in tegra_xusb_pad_init Ma Ke
@ 2025-11-03 11:29 ` Jon Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Jon Hunter @ 2025-11-03 11:29 UTC (permalink / raw)
To: Ma Ke, jckuo, vkoul, kishon, thierry.reding, mchehab, wentong.wu,
sakari.ailus
Cc: linux-phy, linux-tegra, linux-kernel, akpm, stable
On 03/11/2025 10:30, Ma Ke wrote:
> If device_add() fails, do not use device_unregister() for error
> handling. device_unregister() consists two functions: device_del() and
> put_device(). device_unregister() should only be called after
> device_add() succeeded because device_del() undoes what device_add()
> does if successful. Change device_unregister() to put_device() call
> before returning from the function.
>
> As comment of device_add() says, 'if device_add() succeeds, you should
> call device_del() when you want to get rid of it. If device_add() has
> not succeeded, use only put_device() to drop the reference count'.
>
> Found by code review.
>
> Cc: stable@vger.kernel.org
> Fixes: 78876f71b3e9 ("media: pci: intel: ivsc: Add ACE submodule")
Fixes tag is incorrect.
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> drivers/phy/tegra/xusb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index c89df95aa6ca..d89493d68699 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -171,16 +171,16 @@ int tegra_xusb_pad_init(struct tegra_xusb_pad *pad,
>
> err = dev_set_name(&pad->dev, "%s", pad->soc->name);
> if (err < 0)
> - goto unregister;
> + goto put_device;
No mention in the commit message why we call put_device() here, but this
does appear to be correct.
>
> err = device_add(&pad->dev);
> if (err < 0)
> - goto unregister;
> + goto put_device;
>
> return 0;
>
> -unregister:
> - device_unregister(&pad->dev);
> +put_device:
> + put_device(&pad->dev);
> return err;
> }
>
--
nvpublic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-03 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-03 10:30 [PATCH] phy: Fix error handling in tegra_xusb_pad_init Ma Ke
2025-11-03 11:29 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®