* [PATCH] drm/amd/display: remove redundant null check of array 'data'
@ 2017-12-15 10:53 Colin King
2017-12-15 12:18 ` Christian König
2017-12-15 15:05 ` Harry Wentland
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-12-15 10:53 UTC (permalink / raw)
To: Christian König, David Airlie, Harry Wentland, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The null check on aconnector->base.edid_blob_ptr->data is redundant
since data is an array and can never be null. Remove it.
Detected by CoverityScan, CID#1460369 ("Array compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index ccbf10e3bbb6..c388778dbba3 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2725,8 +2725,7 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
};
struct edid *edid;
- if (!aconnector->base.edid_blob_ptr ||
- !aconnector->base.edid_blob_ptr->data) {
+ if (!aconnector->base.edid_blob_ptr) {
DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
aconnector->base.name);
--
2.14.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: remove redundant null check of array 'data'
2017-12-15 10:53 [PATCH] drm/amd/display: remove redundant null check of array 'data' Colin King
@ 2017-12-15 12:18 ` Christian König
2017-12-15 15:05 ` Harry Wentland
1 sibling, 0 replies; 3+ messages in thread
From: Christian König @ 2017-12-15 12:18 UTC (permalink / raw)
To: Colin King, David Airlie, Harry Wentland, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
Am 15.12.2017 um 11:53 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The null check on aconnector->base.edid_blob_ptr->data is redundant
> since data is an array and can never be null. Remove it.
>
> Detected by CoverityScan, CID#1460369 ("Array compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index ccbf10e3bbb6..c388778dbba3 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2725,8 +2725,7 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
> };
> struct edid *edid;
>
> - if (!aconnector->base.edid_blob_ptr ||
> - !aconnector->base.edid_blob_ptr->data) {
> + if (!aconnector->base.edid_blob_ptr) {
> DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
> aconnector->base.name);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: remove redundant null check of array 'data'
2017-12-15 10:53 [PATCH] drm/amd/display: remove redundant null check of array 'data' Colin King
2017-12-15 12:18 ` Christian König
@ 2017-12-15 15:05 ` Harry Wentland
1 sibling, 0 replies; 3+ messages in thread
From: Harry Wentland @ 2017-12-15 15:05 UTC (permalink / raw)
To: Colin King, Koenig, Christian, David Airlie, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
On 2017-12-15 05:53 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The null check on aconnector->base.edid_blob_ptr->data is redundant
> since data is an array and can never be null. Remove it.
>
> Detected by CoverityScan, CID#1460369 ("Array compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index ccbf10e3bbb6..c388778dbba3 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2725,8 +2725,7 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
> };
> struct edid *edid;
>
> - if (!aconnector->base.edid_blob_ptr ||
> - !aconnector->base.edid_blob_ptr->data) {
> + if (!aconnector->base.edid_blob_ptr) {
> DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
> aconnector->base.name);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-15 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-15 10:53 [PATCH] drm/amd/display: remove redundant null check of array 'data' Colin King
2017-12-15 12:18 ` Christian König
2017-12-15 15:05 ` Harry Wentland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®