From: Quentin Monnet <quentin.monnet@netronome.com>
To: Roman Gushchin <guro@fb.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Jakub Kicinski <jakub.kicinski@netronome.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs
Date: Fri, 19 Jan 2018 14:37:25 +0000 [thread overview]
Message-ID: <29c01fd7-8f1e-91bf-0be6-a2b220e0e637@netronome.com> (raw)
In-Reply-To: <20180119141739.GA22398@castle.DHCP.thefacebook.com>
2018-01-19 14:17 UTC+0000 ~ Roman Gushchin <guro@fb.com>
> On Mon, Jan 15, 2018 at 07:32:01PM +0000, Quentin Monnet wrote:
[...]
>> Looks good, thanks Roman!
>> Would you mind updating the map names as well? It seems the
>> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.
>
> Hello, Quentin!
>
>
> Here is the patch.
>
>
> Thanks!
>
> --
>
> From 16245383a894038a63cc1ad4b77629ba704aaa38 Mon Sep 17 00:00:00 2001
> From: Roman Gushchin <guro@fb.com>
> Date: Fri, 19 Jan 2018 14:07:38 +0000
> Subject: [PATCH bpf-next] bpftool: recognize BPF_MAP_TYPE_CPUMAP maps
>
> Add BPF_MAP_TYPE_CPUMAP map type to the list
> of map type recognized by bpftool and define
> corresponding text representation.
>
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Cc: Quentin Monnet <quentin.monnet@netronome.com>
> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Alexei Starovoitov <ast@kernel.org>
> ---
> tools/bpf/bpftool/map.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
> index a152c1a5c94c..f95fa67bb498 100644
> --- a/tools/bpf/bpftool/map.c
> +++ b/tools/bpf/bpftool/map.c
> @@ -66,6 +66,7 @@ static const char * const map_type_name[] = {
> [BPF_MAP_TYPE_HASH_OF_MAPS] = "hash_of_maps",
> [BPF_MAP_TYPE_DEVMAP] = "devmap",
> [BPF_MAP_TYPE_SOCKMAP] = "sockmap",
> + [BPF_MAP_TYPE_CPUMAP] = "cpumap",
> };
>
> static unsigned int get_possible_cpus(void)
>
Good, thank you!
Acked-by: Quentin Monnet <quentin.monnet@netronome.com>
next prev parent reply other threads:[~2018-01-19 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 19:16 Roman Gushchin
2018-01-15 19:32 ` Quentin Monnet
2018-01-15 19:49 ` Roman Gushchin
2018-01-16 1:52 ` Daniel Borkmann
2018-01-19 14:17 ` Roman Gushchin
2018-01-19 14:37 ` Quentin Monnet [this message]
2018-01-19 22:19 ` Daniel Borkmann
2018-01-19 22:23 ` Jakub Kicinski
2018-01-15 19:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29c01fd7-8f1e-91bf-0be6-a2b220e0e637@netronome.com \
--to=quentin.monnet@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=guro@fb.com \
--cc=jakub.kicinski@netronome.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®