From: John Youn <John.Youn@synopsys.com>
To: Doug Anderson <dianders@chromium.org>,
John Youn <John.Youn@synopsys.com>
Cc: Yunzhi Li <lyz@rock-chips.com>,
"jwerner@chromium.org" <jwerner@chromium.org>,
"huangtao@rock-chips.com" <huangtao@rock-chips.com>,
"cf@rock-chips.com" <cf@rock-chips.com>,
"hl@rock-chips.com" <hl@rock-chips.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams()
Date: Mon, 5 Oct 2015 22:02:06 +0000 [thread overview]
Message-ID: <2B3535C5ECE8B5419E3ECBE30077290901DC3875D2@US01WEMBX2.internal.synopsys.com> (raw)
In-Reply-To: <CAD=FV=W5t15-aJo3W_Ym-GeLDq_xyNcAFsZcUAt61CYO+vwh=g@mail.gmail.com>
On 10/1/2015 1:50 PM, Doug Anderson wrote:
> John,
>
> On Tue, Aug 18, 2015 at 5:19 PM, John Youn <John.Youn@synopsys.com> wrote:
>> Hi Yunzhi,
>>
>> My concern is with the delays due to calling the dwc2_core_reset
>> during probe. You could factor out the assertion of the core
>> soft reset from the dwc2_core_reset and just use that before
>> calling dwc2_get_hwparams().
>>
>> You had previously addressed the lengthy probe time issue here:
>> http://marc.info/?l=linux-usb&m=142357721304377
>>
>> This reducing delays patch looks reasonable to me and I think it
>> should get merged also. I'll do some testing with it later this
>> week.
>
> Note: you can also avoid the extra reset during probe with something
> like <https://chromium-review.googlesource.com/#/c/303152/>. I'm
> happy to post that up if you want, though it depends on lyz's patch.
>
> ...in Chrome OS we've also just landed lyz's patch to reduce delays.
> If there's any fallout I'll report on the list.
>
> -Doug
>
Yes, I appreciate if you could submit that. I'd like to merge lyz's
reduce delays, lyz's bug fix for hwparams, and your fix for double
reset.
The gadget side will also need something similar which I can do if
needed. Do you guys run gadget mode?
Regards,
John
next prev parent reply other threads:[~2015-10-05 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 9:40 Yunzhi Li
2015-08-18 23:03 ` Doug Anderson
2015-08-19 0:19 ` John Youn
2015-10-01 20:50 ` Doug Anderson
2015-10-05 22:02 ` John Youn [this message]
2015-10-08 0:50 ` Doug Anderson
2015-10-09 21:19 ` John Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2B3535C5ECE8B5419E3ECBE30077290901DC3875D2@US01WEMBX2.internal.synopsys.com \
--to=john.youn@synopsys.com \
--cc=cf@rock-chips.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lyz@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®