From: hayeswang <hayeswang@realtek.com>
To: "'Francois Romieu'" <romieu@fr.zoreil.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next 2/7] r8169: Update PHY settings of RTL8111G
Date: Tue, 2 Apr 2013 10:19:17 +0800 [thread overview]
Message-ID: <2CDCEE66B3D64940AB7259FBACFFDC6F@realtek.com.tw> (raw)
In-Reply-To: <20130401222048.GA19335@electric-eye.fr.zoreil.com>
Francois Romieu [mailto:romieu@fr.zoreil.com]
> Sent: Tuesday, April 02, 2013 6:21 AM
> To: Hayeswang
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 2/7] r8169: Update PHY settings
> of RTL8111G
>
> Hayes Wang <hayeswang@realtek.com> :
> > - Replace the current settings with rtl_writephy and rtl_readphy.
> > For the hardware, the settings are same with previous ones. This
> > make the setting method like the previous chips.
> > - Add new PHY settings.
>
> Would you mind spliting it in two ?
OK.
[...]
> > - if (r8168_phy_ocp_read(tp, 0xa466) & 0x0100)
> > - rtl_w1w0_phy_ocp(tp, 0xc41a, 0x0002, 0x0000);
> > - else
> > - rtl_w1w0_phy_ocp(tp, 0xbcc4, 0x0000, 0x0002);
> ^^^^^^
> This one was not right, was it ?
No, it was not right. It seems a mistake for copying and pasting.
next prev parent reply other threads:[~2013-04-02 2:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 13:55 [PATCH net-next 1/7] r8169: Remove firmware code Hayes Wang
2013-04-01 13:55 ` [PATCH net-next 2/7] r8169: Update PHY settings of RTL8111G Hayes Wang
2013-04-01 22:20 ` Francois Romieu
2013-04-02 2:19 ` hayeswang [this message]
2013-04-01 13:55 ` [PATCH net-next 3/7] r8169: Modify the method for setting firmware Hayes Wang
2013-04-01 13:55 ` [PATCH net-next 4/7] r8169: Update the RTL8111G parameters Hayes Wang
2013-04-01 13:55 ` [PATCH net-next 5/7] r8169: add a new chip for RTL8111G Hayes Wang
2013-04-01 22:22 ` Francois Romieu
2013-04-02 2:39 ` hayeswang
2013-04-02 23:20 ` Francois Romieu
2013-04-02 23:26 ` David Miller
2013-04-01 13:55 ` [PATCH net-next 6/7] r8169: add a new chip for RTL8106E Hayes Wang
2013-04-01 22:23 ` Francois Romieu
2013-04-02 2:59 ` hayeswang
2013-04-01 13:55 ` [PATCH net-next 7/7] r8169: fix could not dump registers Hayes Wang
2013-04-01 14:07 ` Sergei Shtylyov
2013-04-01 22:24 ` Francois Romieu
2013-04-02 8:23 ` [PATCH v2 net-next 1/8] r8169: Remove firmware code Hayes Wang
2013-04-02 8:23 ` [PATCH v2 net-next 2/8] r8169: Modify the mothod for PHY settings of RTL8111G Hayes Wang
2013-04-02 8:23 ` [PATCH v2 net-next 3/8] r8169: Update " Hayes Wang
2013-04-02 8:23 ` [PATCH v2 net-next 4/8] r8169: Modify the method for setting firmware Hayes Wang
2013-04-02 8:23 ` [PATCH v2 net-next 5/8] r8169: Update the RTL8111G parameters Hayes Wang
2013-04-02 8:23 ` [PATCH v2 net-next 6/8] r8169: add a new chip for RTL8111G Hayes Wang
2013-04-02 22:27 ` Francois Romieu
2013-04-03 3:03 ` hayeswang
2013-04-03 5:59 ` Francois Romieu
2013-04-02 8:23 ` [PATCH v2 net-next 7/8] r8169: adjust the flow of hw_start Hayes Wang
2013-04-02 8:23 ` [PATCH v2 net-next 8/8] r8169: add a new chip for RTL8106E Hayes Wang
2013-04-04 21:47 ` [PATCH v2 net-next 1/8] r8169: Remove firmware code David Miller
2013-04-04 23:42 ` Francois Romieu
2013-04-07 20:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2CDCEE66B3D64940AB7259FBACFFDC6F@realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome