From: Paul Cercueil <paul@crapouillou.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: 周琰杰 <zhouyanjie@wanyeetech.com>,
linux-kernel@vger.kernel.org,
"GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com,
rick.tyliu@ingenic.com, yanfei.li@ingenic.com,
sernia.zhou@foxmail.com, zhenwenjin@gmail.com
Subject: Re: [PATCH v4 0/3] pinctrl: Ingenic: Add support for SSI and I2S pins.
Date: Sat, 10 Oct 2020 21:10:14 +0200 [thread overview]
Message-ID: <2L20IQ.FYURHZYQ6ZCT3@crapouillou.net> (raw)
In-Reply-To: <CACRpkda1B3LcGWc1PhXNgi-6JxapiKY4F_94c6dk4eBLgVGBJg@mail.gmail.com>
Hi Linus, Zhou,
The first patch is bogus. Half of the SSI pins are wrong (GPIO chip D/E
start at 0x60/0x80 respectively).
Sorry for not catching that before.
-Paul
Le mar. 29 sept. 2020 à 14:48, Linus Walleij
<linus.walleij@linaro.org> a écrit :
> On Sun, Sep 13, 2020 at 8:59 AM 周琰杰 (Zhou Yanjie)
> <zhouyanjie@wanyeetech.com> wrote:
>
>> 1.Add SSI pins support for JZ4770 and JZ4780.
>> 2.Correct the pullup and pulldown parameters of JZ4780.
>> 3.Add I2S pins support for JZ4780, X1000, X1500, and X1830.
>>
>> v2->v3:
>> 1.Add Paul Cercueil's Reviewed-by.
>> 2.Fix bug about PE15's pull-up parameter.
>
> This v3 patch set applied!
>
> Thank you so much for your hard work!
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2020-10-10 22:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 6:58 周琰杰 (Zhou Yanjie)
2020-09-13 6:58 ` [PATCH v4 1/3] pinctrl: Ingenic: Add SSI pins support for JZ4770 and JZ4780 周琰杰 (Zhou Yanjie)
2020-09-13 6:58 ` [PATCH v4 2/3] pinctrl: Ingenic: Correct the pullup and pulldown parameters of JZ4780 周琰杰 (Zhou Yanjie)
2020-09-13 6:58 ` [PATCH v4 3/3] pinctrl: Ingenic: Add I2S pins support for Ingenic SoCs 周琰杰 (Zhou Yanjie)
2020-09-29 12:48 ` [PATCH v4 0/3] pinctrl: Ingenic: Add support for SSI and I2S pins Linus Walleij
2020-10-10 19:10 ` Paul Cercueil [this message]
2020-10-10 19:25 ` [PATCH] pinctrl: ingenic: Fix invalid SSI pins Paul Cercueil
2020-10-11 16:30 ` Zhou Yanjie
2020-10-19 13:48 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2L20IQ.FYURHZYQ6ZCT3@crapouillou.net \
--to=paul@crapouillou.net \
--cc=aric.pzqi@ingenic.com \
--cc=dongsheng.qiu@ingenic.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rick.tyliu@ingenic.com \
--cc=sernia.zhou@foxmail.com \
--cc=yanfei.li@ingenic.com \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®