mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konstantin Olifer <kolifer@gmail.com>
To: mark.gross@intel.com, dougthompson@xmission.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fsb ecc don't work correctly on any intel cpu but the xeon!  fixed.
Date: Sat, 26 Dec 2009 16:58:39 +0300	[thread overview]
Message-ID: <2a20a1830912260558qe31c445te452d57b77979e87@mail.gmail.com> (raw)

Hello,

Kernel 2.6.32 e752x_edac suppose that fsb ECC exist, for example, on
Celeron + 3100. That is wrong. ECC FSB supported only on Xeon for our
vision and datasheet from developer intel www. Fixed.

Thank you.

Wish a Happy Christmas and Happy New Year!


Best regards,
Konstantin




--- ./linux-2.6.32/drivers/edac/e752x_edac.c.orig	2009-12-03
06:51:21.000000000 +0300
+++ ./linux-2.6.32/drivers/edac/e752x_edac.c	2009-12-26 16:29:14.000000000 +0300
@@ -1072,11 +1072,8 @@ fail:
 }

 /* Setup system bus parity mask register.
- * Sysbus parity supported on:
- *   e7320/e7520/e7525 + Xeon
- *   i3100 + Xeon/Celeron
- * Sysbus parity not supported on:
- *   i3100 + Pentium M/Celeron M/Core Duo/Core2 Duo
+ * Sysbus parity supported _only on_:
+ * e7320/e7520/e7525 + Xeon
  */
 static void e752x_init_sysbus_parity_mask(struct e752x_pvt *pvt)
 {
@@ -1084,13 +1081,11 @@ static void e752x_init_sysbus_parity_mas
 	struct pci_dev *dev = pvt->dev_d0f1;
 	int enable = 1;

-	/* Allow module parameter override, else see if CPU supports parity */
+	/* Allow module paramter override, else see if CPU supports parity */
 	if (sysbus_parity != -1) {
 		enable = sysbus_parity;
 	} else if (cpu_id[0] &&
-		   ((strstr(cpu_id, "Pentium") && strstr(cpu_id, " M ")) ||
-		    (strstr(cpu_id, "Celeron") && strstr(cpu_id, " M ")) ||
-		    (strstr(cpu_id, "Core") && strstr(cpu_id, "Duo")))) {
+		   !strstr(cpu_id, "Xeon")) {
 		e752x_printk(KERN_INFO, "System Bus Parity not "
 			     "supported by CPU, disabling\n");
 		enable = 0;

                 reply	other threads:[~2009-12-26 13:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a20a1830912260558qe31c445te452d57b77979e87@mail.gmail.com \
    --to=kolifer@gmail.com \
    --cc=dougthompson@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.gross@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®