mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: 孙守鑫 <sunshouxin@chinatelecom.cn>
To: j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
	davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	jay.vosburgh@canonical.com, nikolay@nvidia.com,
	huyd12@chinatelecom.cn, 孙守鑫 <sunshouxin@chinatelecom.cn>
Subject: Re: [PATCH v10] net: bonding: Add support for IPV6 ns/na to balance-alb/balance-tlb mode
Date: Fri, 28 Jan 2022 10:45:59 +0800	[thread overview]
Message-ID: <2a2c18ff-a2d2-acc2-83fa-b1f37e4c9199@chinatelecom.cn> (raw)
In-Reply-To: <20220128023916.100071-1-sunshouxin@chinatelecom.cn>


Any progress?


在 2022/1/28 10:39, Sun Shouxin 写道:
> Since ipv6 neighbor solicitation and advertisement messages
> isn't handled gracefully in bond6 driver, we can see packet
> drop due to inconsistency between mac address in the option
> message and source MAC .
>
> Another examples is ipv6 neighbor solicitation and advertisement
> messages from VM via tap attached to host bridge, the src mac
> might be changed through balance-alb mode, but it is not synced
> with Link-layer address in the option message.
>
> The patch implements bond6's tx handle for ipv6 neighbor
> solicitation and advertisement messages.
>
> Suggested-by: Hu Yadi <huyd12@chinatelecom.cn>
> Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
> Signed-off-by: Sun Shouxin <sunshouxin@chinatelecom.cn>
> ---
> v9->v10:
> - add IPv6 header pull in alb_determine_nd.
> - combine bond_xmit_alb_slave_get's IPv6 header
> pull with alb_determine_nd's
> ---
>   drivers/net/bonding/bond_alb.c | 40 ++++++++++++++++++++++++++++++++--
>   1 file changed, 38 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
> index 533e476988f2..d9da6eb7f5c2 100644
> --- a/drivers/net/bonding/bond_alb.c
> +++ b/drivers/net/bonding/bond_alb.c
> @@ -1269,6 +1269,37 @@ static int alb_set_mac_address(struct bonding *bond, void *addr)
>   	return res;
>   }
>   
> +/* determine if the packet is NA or NS */
> +static bool __alb_determine_nd(struct icmp6hdr *hdr)
> +{
> +	if (hdr->icmp6_type == NDISC_NEIGHBOUR_ADVERTISEMENT ||
> +	    hdr->icmp6_type == NDISC_NEIGHBOUR_SOLICITATION) {
> +		return true;
> +	}
> +
> +	return false;
> +}
> +
> +static bool alb_determine_nd(struct sk_buff *skb, struct bonding *bond)
> +{
> +	struct ipv6hdr *ip6hdr;
> +	struct icmp6hdr *hdr;
> +
> +	if (!pskb_network_may_pull(skb, sizeof(*ip6hdr)))
> +		return true;
> +
> +	ip6hdr = ipv6_hdr(skb);
> +	if (ip6hdr->nexthdr == IPPROTO_ICMPV6) {
> +		if (!pskb_may_pull(skb, sizeof(*ip6hdr) + sizeof(*hdr)))
> +			return true;
> +
> +		hdr = icmp6_hdr(skb);
> +		return __alb_determine_nd(hdr);
> +	}
> +
> +	return false;
> +}
> +
>   /************************ exported alb functions ************************/
>   
>   int bond_alb_initialize(struct bonding *bond, int rlb_enabled)
> @@ -1348,8 +1379,11 @@ struct slave *bond_xmit_tlb_slave_get(struct bonding *bond,
>   	/* Do not TX balance any multicast or broadcast */
>   	if (!is_multicast_ether_addr(eth_data->h_dest)) {
>   		switch (skb->protocol) {
> -		case htons(ETH_P_IP):
>   		case htons(ETH_P_IPV6):
> +			if (alb_determine_nd(skb, bond))
> +				break;
> +			fallthrough;
> +		case htons(ETH_P_IP):
>   			hash_index = bond_xmit_hash(bond, skb);
>   			if (bond->params.tlb_dynamic_lb) {
>   				tx_slave = tlb_choose_channel(bond,
> @@ -1432,10 +1466,12 @@ struct slave *bond_xmit_alb_slave_get(struct bonding *bond,
>   			break;
>   		}
>   
> -		if (!pskb_network_may_pull(skb, sizeof(*ip6hdr))) {
> +		if (alb_determine_nd(skb, bond)) {
>   			do_tx_balance = false;
>   			break;
>   		}
> +
> +		/* The IPv6 header is pulled by alb_determine_nd */
>   		/* Additionally, DAD probes should not be tx-balanced as that
>   		 * will lead to false positives for duplicate addresses and
>   		 * prevent address configuration from working.
>
> base-commit: dd81e1c7d5fb126e5fbc5c9e334d7b3ec29a16a0

  reply	other threads:[~2022-01-28  2:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28  2:39 Sun Shouxin
2022-01-28  2:45 ` 孙守鑫 [this message]
2022-01-28  2:51 ` Jakub Kicinski
  -- strict thread matches above, loose matches on Subject: below --
2022-01-25 14:24 Sun Shouxin
2022-01-28  2:47 ` Jakub Kicinski
2022-01-28 11:46   ` 孙守鑫

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a2c18ff-a2d2-acc2-83fa-b1f37e4c9199@chinatelecom.cn \
    --to=sunshouxin@chinatelecom.cn \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=huyd12@chinatelecom.cn \
    --cc=j.vosburgh@gmail.com \
    --cc=jay.vosburgh@canonical.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®