From: Robin van der Gracht <robin@protonic.nl>
To: Mianhan Liu <liumh1@shanghaitech.edu.cn>
Cc: Miguel Ojeda <ojeda@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c
Date: Thu, 30 Sep 2021 08:37:35 +0200 [thread overview]
Message-ID: <2a385c2e6fc133a9d93bded92a946e4f@protonic.nl> (raw)
In-Reply-To: <20210928191509.3806-1-liumh1@shanghaitech.edu.cn>
On 2021-09-28 21:15, Mianhan Liu wrote:
> ht16k33.c hasn't use any macro or function declared in linux/slab.h.
> Thus, these files can be removed from ht16k33.c safely without
> affecting the compilation of the drivers/auxdisplay/ module
>
> Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>
>
> ---
> drivers/auxdisplay/ht16k33.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
> index 1e69cc6d2..6502bc00e 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -13,7 +13,6 @@
> #include <linux/i2c.h>
> #include <linux/of.h>
> #include <linux/fb.h>
> -#include <linux/slab.h>
> #include <linux/backlight.h>
> #include <linux/input.h>
> #include <linux/input/matrix_keypad.h>
Acked-by: Robin van der Gracht <robin@protonic.nl>
next prev parent reply other threads:[~2021-09-30 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 19:15 Mianhan Liu
2021-09-30 6:37 ` Robin van der Gracht [this message]
2021-10-21 22:08 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a385c2e6fc133a9d93bded92a946e4f@protonic.nl \
--to=robin@protonic.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=liumh1@shanghaitech.edu.cn \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®