* [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c
@ 2021-09-28 19:15 Mianhan Liu
2021-09-30 6:37 ` Robin van der Gracht
2021-10-21 22:08 ` Miguel Ojeda
0 siblings, 2 replies; 3+ messages in thread
From: Mianhan Liu @ 2021-09-28 19:15 UTC (permalink / raw)
To: Robin van der Gracht, Miguel Ojeda; +Cc: linux-kernel, Mianhan Liu
ht16k33.c hasn't use any macro or function declared in linux/slab.h.
Thus, these files can be removed from ht16k33.c safely without
affecting the compilation of the drivers/auxdisplay/ module
Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>
---
drivers/auxdisplay/ht16k33.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index 1e69cc6d2..6502bc00e 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -13,7 +13,6 @@
#include <linux/i2c.h>
#include <linux/of.h>
#include <linux/fb.h>
-#include <linux/slab.h>
#include <linux/backlight.h>
#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c
2021-09-28 19:15 [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c Mianhan Liu
@ 2021-09-30 6:37 ` Robin van der Gracht
2021-10-21 22:08 ` Miguel Ojeda
1 sibling, 0 replies; 3+ messages in thread
From: Robin van der Gracht @ 2021-09-30 6:37 UTC (permalink / raw)
To: Mianhan Liu; +Cc: Miguel Ojeda, linux-kernel
On 2021-09-28 21:15, Mianhan Liu wrote:
> ht16k33.c hasn't use any macro or function declared in linux/slab.h.
> Thus, these files can be removed from ht16k33.c safely without
> affecting the compilation of the drivers/auxdisplay/ module
>
> Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>
>
> ---
> drivers/auxdisplay/ht16k33.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
> index 1e69cc6d2..6502bc00e 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -13,7 +13,6 @@
> #include <linux/i2c.h>
> #include <linux/of.h>
> #include <linux/fb.h>
> -#include <linux/slab.h>
> #include <linux/backlight.h>
> #include <linux/input.h>
> #include <linux/input/matrix_keypad.h>
Acked-by: Robin van der Gracht <robin@protonic.nl>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c
2021-09-28 19:15 [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c Mianhan Liu
2021-09-30 6:37 ` Robin van der Gracht
@ 2021-10-21 22:08 ` Miguel Ojeda
1 sibling, 0 replies; 3+ messages in thread
From: Miguel Ojeda @ 2021-10-21 22:08 UTC (permalink / raw)
To: Mianhan Liu; +Cc: Robin van der Gracht, Miguel Ojeda, linux-kernel
On Tue, Sep 28, 2021 at 9:15 PM Mianhan Liu <liumh1@shanghaitech.edu.cn> wrote:
>
> ht16k33.c hasn't use any macro or function declared in linux/slab.h.
> Thus, these files can be removed from ht16k33.c safely without
> affecting the compilation of the drivers/auxdisplay/ module
Applied, thanks!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-21 22:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 19:15 [PATCH -next] drivers/auxdisplay/ht16k33.c: remove superfluous header files from ht16k33.c Mianhan Liu
2021-09-30 6:37 ` Robin van der Gracht
2021-10-21 22:08 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®